690828 - Dropdown of SELECT does not work properly

Status: RESOLVED DUPLICATE of bug 691725

(Core :: Widget: Win32, defect)

Description

[Alice0775 White]

Attachment: testcase

Build Identifier:
http://hg.mozilla.org/mozilla-central/rev/b5b082d183d0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0a1) Gecko/20110930 Firefox/10.0a1 ID:20110930030850

Dropdoen of SELECT does not work properly.
Dropdown disappears immediately when I click dropdown arrow.
Dropdown does not appear when I click dropdown arrow 2nd time.

Reproducible: Always

Steps to Reproduce:
1. Start Firefox with clean profile
2  Open testcase
3. Click dropdown arrow

Actual Results:

Dropdoen of SELECT does not work properly.

Expected Results:

Dropdoen of SELECT should work properly.

Regression window(m-c hourly)
Works;
http://hg.mozilla.org/mozilla-central/rev/cb4b93331e4f
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0a1) Gecko/20110929 Firefox/10.0a1 ID:20110929030852
Fails:
http://hg.mozilla.org/mozilla-central/rev/e7854b4d29ba
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0a1) Gecko/20110929 Firefox/10.0a1 ID:20110929012133
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=cb4b93331e4f&tochange=e7854b4d29ba

Comment 1

[Alice0775 White]

s/Dropdoen/Dropdown/

Comment 3

[Boris Zbarsky [:bzbarsky]]

Bug 687393 and bug 675553 are the two that jump at at me as maybe somehow being responsible, though both are long shots....

Requesting tracking for this regression.

Comment 4

[alexander :surkov (:asurkov)]

(In reply to Boris Zbarsky (:bz) from comment #3)
> Bug 687393 and bug 675553 are the two that jump at at me as maybe somehow
> being responsible, though both are long shots....

Bug 687393 is pure a11y fix, it cannot be guilty of UI regressions

Comment 5

[Jeff Muizelaar [:jrmuizel]]

I have a try build of 9672c3995eea going which will show up here:
https://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-d0df594f9280/

If the test case works in this build that means e7854b4d29ba is to blame.

Comment 6

[Alice0775 White]

In addition to the comment #0,
In my environments,
The problem happens on Wndows 7x64 Clasic and Aero Bacic, but not Aero.
And the problem does not happen without HWA.

Comment 7

[Alice0775 White]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #5)
> I have a try build of 9672c3995eea going which will show up here:
> https://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/
> [e-mail]-d0df594f9280/
> 
> If the test case works in this build that means e7854b4d29ba is to blame.

The try server build works fine. The try server build fixes the problem of comment #0.
http://hg.mozilla.org/try/rev/d0df594f9280
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0a1) Gecko/20110930 Firefox/10.0a1 ID:20110930202550

Comment 8

[Alice0775 White]

screen capture
http://www.youtube.com/watch?v=5ClYAiSZmkw

Comment 9

[(no longer active)]

As a first step I would bisect on the changes in the PRBool patch made to widget/windows.

Comment 10

[(no longer active)]

Here's one possible way that this might have happened.  If we had a PRBool containing a value other than 1 and 0 which was passed to the Windows API, the conversion to bool will almost certainly break it.

Comment 11

[(no longer active)]

Bas might also be interested to bisect the patch on the changes made to Windows-specific graphics code.

Comment 12

[Ken]

Attachment: Example Selection problem, XP w/o graphics HWA

Different bug?  See below -----.

The attached screen shots show what happens when I move off the 'select Dropdown box' on the following examples:

1) On http://forums.mozillazine.org/ (Post reply page) with animated GIF's:
  When I select the 'font size' dropdown menu everything displays OK, but when I move off the selection box the whole box disappears.
  Then, when I move back under/over where the select box should be a portion of it is redisplayed.

2) On http://www.tvguide.com/listings/ (time or date selection box):
  When I move off the Select box, over any 'hyper link' next to the box, that portion of the Select box is wiped out by the link text.
  If I move back over the Selection box that portion of the Box is redisplayed.

------
I'm not sure if this should be a separate bug or not. But,
- the problem happens with the 'select Dropdown box';
- it is fixed by the same try server build in Comment 5;
- and the problem sounds similar ('select Dropdown box' display not working correctly).

My configuration is different than Alice's in Comment 6; Win XP, and no Graphics HWA.
I have tried testing this in 'safe mode' and 'safe mode/ with a clean profile'. Same results.

Mozilla/5.0 (Windows NT 5.1; rv:10.0a1) Gecko/20111003 Firefox/10.0a1 ID:20111003030859

Comment 13

[Ken]

Change, Comment 12 [2)...'hyper link'] to ['table cell/link text'].

Comment 14

[Michael Wu [:mwu]]

Attachment: Fix some wrong returns

This appears to fix the issue. Not sure why. But, these lines shouldn't be returning error codes in a function that returns bool.

Comment 15

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 564637 [details] [diff] [review]
Fix some wrong returns

Review of attachment 564637 [details] [diff] [review]:
-----------------------------------------------------------------

I don't know either, but this is clearly correct...

Comment 16

[Michael Wu [:mwu]]

Hmm so I was wrong. It might just be an issue in MSVC. My own opt builds don't show the issue and the tinderbox debug builds don't have problems. I'm doing my own pgo now to see if that has the regression.

Comment 17

[Alice0775 White]

Fixed by 691725.

I cannot reproduce the problem anymore.
http://hg.mozilla.org/mozilla-central/rev/c3a50afc2243
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0a1) Gecko/20111007 Firefox/10.0a1 ID:20111007031227

Comment 18

[Michael Wu [:mwu]]

Duping to 691725 since this has the same root cause.