Closed
Bug 690857
Opened 13 years ago
Closed 13 years ago
Windows 7 Taskbar Previews broken on Nightly
Categories
(Core :: Widget: Win32, defect)
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: murph.0912, Assigned: rain1)
References
Details
(Keywords: regression, Whiteboard: [inbound])
Attachments
(3 files)
Image of Taskbar Preview Issue
Tab content fails to display in taskbar previews
STR:
1. In new profile, check option to display previews in Taskbar.
2. Hover mouse over taskbar to display of all tabs open in browser.
Expected:
Preview of content of each tab will be shown.
Actual:
See Image attached.
|
Reporter | |
Updated•13 years ago
|
Keywords: regression
|
|
Reporter | |
Comment 1•13 years ago
|
||
Regression range based on Nightly nightly buids:
Changeset cb4b93331e4f: OK
Changeset b5b082d183d0: Not OK
It's similar for me, but my tab previews are the various tabs' favicons.
|
||
Comment 3•13 years ago
|
||
In addition it also affects if you have other Firefox windows open. Only if the option is enabled.
|
|
||
Comment 4•13 years ago
|
||
|
Assignee | |
Comment 5•13 years ago
|
||
Yes, I can reproduce. Looking into it.
|
|
Assignee | |
Comment 6•13 years ago
|
||
I backed out bug 515907 and the problem still persists, plus that bug doesn't really touch the part of the code that generates previews, so I really doubt it's that.
|
|
Assignee | |
Updated•13 years ago
|
Summary: Bug 515907 Breaks Win7 Taskbar Previews on Nightly → Windows 7 Taskbar Previews broken on Nightly
|
|
Assignee | |
Updated•13 years ago
|
Component: General → Widget: Win32
Product: Firefox → Core
QA Contact: general → win32
|
|
Assignee | |
Comment 7•13 years ago
|
||
mwu, could your PRBool to bool change have caused this? See <https://hg.mozilla.org/mozilla-central/diff/e7854b4d29ba/widget/src/windows/TaskbarTabPreview.cpp>.
|
|
Assignee | |
Comment 8•13 years ago
|
||
Yep, I'm pretty sure that's the reason.
|
|
Assignee | |
Comment 9•13 years ago
|
||
Yep, fallout. We didn't catch this because we were assuming (and not type checking) that PRBool = BOOL.
|
||
Updated•13 years ago
|
Attachment #563827 -
Flags: review?(mwu) → review+
|
|
Assignee | |
Comment 10•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
|
|
Assignee | |
Comment 11•13 years ago
|
||
Ugh, sorry, I always slip up with marking inbound patches as fixed.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: [inbound]
Target Milestone: mozilla10 → ---
|
|
Assignee | |
Updated•13 years ago
|
|
||
Comment 12•13 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
|
|
Reporter | |
Comment 13•13 years ago
|
||
I just grabbed the Nightly hourly (C-set ID 164fd1bbd06f) containing the needed patch and can confirm that Win7 Taskbar Previews have been fixed.
Thanks for the fix. Sorry for the initial misdirection. Just think of it as a little test. ;-)
|
|
Assignee | |
Comment 14•13 years ago
|
||
No worries: my patch was the obvious one to blame.
You need to log in
before you can comment on or make changes to this bug.
Description
•