690906 - Alternate table rows

Status: VERIFIED FIXED

(Socorro :: General, task)

Description

[Schalk Neethling [:espressive]]

Hi there,

It has been suggested, and I agree, that alternate row colors on the report tables will increase readability.

To enable this is simple, just not sure where to add these on Github in the Socorro repo.

The HTML would be:

add a class entitled zebra to tables that needs striping i.e.

<table class="something zebra">
....
</table>

The CSS would be:

/* whatever color this needs to be */
.zebra .odd {
    background-color: #edecec;
}

And the JS

var zebra = function(table) {
    table.find("tbody tr:odd").addClass("odd");
},
toStripe = !!$(".zebra").length;

if(toStripe) {				
    $(".zebra").each(function() {
        zebra($(this));
    });
}

Comment 1

[Lonnen :lonnen]

There is already zebra striping code in the css on the admin view. You may want to check there to see if you can refactor that for reuse.

Comment 2

[Schalk Neethling [:espressive]]

Hey Chris,

Still figuring out where everything is. When you say in the admin view, where exactly is this?

Comment 3

[Lonnen :lonnen]

Sure... in the lower right corner is an 'admin' link. Follow that, then the 'branch data sources' link. 

The source is here: https://github.com/mozilla/socorro/blob/master/webapp-php/application/views/admin/branch_data_sources.php

Comment 4

[Schalk Neethling [:espressive]]

Hey Chris,

When going to https://crash-stats.mozilla.com/products/Firefox I see a log in link on the lower right but, I do not seem to have access to this area.

I assume this is the admin you were talking about unless I am completely on the wrong track ;)

Thanks for your help.

Comment 5

[Lonnen :lonnen]

Yep. On a local install (vagrant) it should let you right in. You can get admin access to crash-stats by filing a bug for Server Ops: Account Requests through the mozilla.org product in bugzilla.

Comment 6

[Schalk Neethling [:espressive]]

Hey Chris,

My local Socorro still has no data as I am waiting for VPN access to get hold of the DB backup. I will file a bug regarding access to the live site in mean time as well.

Thanks

Comment 7

[Schalk Neethling [:espressive]]

Sent pull request to resolve this bug: https://github.com/mozilla/socorro/pull/72

Turned out to be a very small CS change.

Comment 8

[Schalk Neethling [:espressive]]

Resolved? I believe so

Comment 9

[Schalk Neethling [:espressive]]

Pull request landed: https://github.com/mozilla/socorro/pull/72

Comment 10

[Trif Andrei-Alin[:AlinT]]

Verified on https://crash-stats-dev.allizom.org and table rows have alternate colors(grey and white).

Comment 11

[Schalk Neethling [:espressive]]

[:rhelmer] Are there issues with this fix?