Add strict equality inline paths for objects and strings

RESOLVED FIXED in mozilla10

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: billm, Assigned: billm)

Tracking

(Blocks: 1 bug)

unspecified
mozilla10
x86
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 563903 [details] [diff] [review]
patch

This gives a modest speedup on earley-boyer.
Attachment #563903 - Flags: review?(bhackett1024)
Comment on attachment 563903 [details] [diff] [review]
patch

Can you paste numbers for the earley-boyer speedup you're getting, or a microbenchmark before/after?
Attachment #563903 - Flags: review?(bhackett1024) → review+
(Assignee)

Comment 2

6 years ago
In the modified earley-boyer test case from bug 642001 comment 10, I get these numbers:

with patch: 3.074s
without patch: 3.434s
(Assignee)

Comment 3

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/70433779ffa7
Target Milestone: --- → mozilla10

Comment 4

6 years ago
https://hg.mozilla.org/mozilla-central/rev/70433779ffa7
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

6 years ago
Depends on: 693166
Comment on attachment 563903 [details] [diff] [review]
patch

>+            return jumpAndTrace(fast, target, &sj) ? Compile_Okay : Compile_Error;
>+        } else {

r=me to fix this else after return in moved code, any time.

/be

Updated

6 years ago
Depends on: 693311
You need to log in before you can comment on or make changes to this bug.