Last Comment Bug 690974 - Add strict equality inline paths for objects and strings
: Add strict equality inline paths for objects and strings
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: x86 Linux
: -- normal (vote)
: mozilla10
Assigned To: Bill McCloskey (:billm)
:
Mentors:
Depends on: 693166 693311
Blocks: 642001
  Show dependency treegraph
 
Reported: 2011-09-30 17:31 PDT by Bill McCloskey (:billm)
Modified: 2011-10-10 08:16 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (10.80 KB, patch)
2011-09-30 17:31 PDT, Bill McCloskey (:billm)
bhackett1024: review+
Details | Diff | Splinter Review

Description Bill McCloskey (:billm) 2011-09-30 17:31:06 PDT
Created attachment 563903 [details] [diff] [review]
patch

This gives a modest speedup on earley-boyer.
Comment 1 Brian Hackett (:bhackett) 2011-10-03 14:35:18 PDT
Comment on attachment 563903 [details] [diff] [review]
patch

Can you paste numbers for the earley-boyer speedup you're getting, or a microbenchmark before/after?
Comment 2 Bill McCloskey (:billm) 2011-10-05 15:12:51 PDT
In the modified earley-boyer test case from bug 642001 comment 10, I get these numbers:

with patch: 3.074s
without patch: 3.434s
Comment 4 Ed Morley [:emorley] 2011-10-07 04:20:18 PDT
https://hg.mozilla.org/mozilla-central/rev/70433779ffa7
Comment 5 Brendan Eich [:brendan] 2011-10-09 13:46:01 PDT
Comment on attachment 563903 [details] [diff] [review]
patch

>+            return jumpAndTrace(fast, target, &sj) ? Compile_Okay : Compile_Error;
>+        } else {

r=me to fix this else after return in moved code, any time.

/be

Note You need to log in before you can comment on or make changes to this bug.