Closed Bug 690974 Opened 10 years ago Closed 10 years ago

Add strict equality inline paths for objects and strings

Categories

(Core :: JavaScript Engine, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla10

People

(Reporter: billm, Assigned: billm)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
This gives a modest speedup on earley-boyer.
Attachment #563903 - Flags: review?(bhackett1024)
Comment on attachment 563903 [details] [diff] [review]
patch

Can you paste numbers for the earley-boyer speedup you're getting, or a microbenchmark before/after?
Attachment #563903 - Flags: review?(bhackett1024) → review+
In the modified earley-boyer test case from bug 642001 comment 10, I get these numbers:

with patch: 3.074s
without patch: 3.434s
https://hg.mozilla.org/mozilla-central/rev/70433779ffa7
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Depends on: 693166
Comment on attachment 563903 [details] [diff] [review]
patch

>+            return jumpAndTrace(fast, target, &sj) ? Compile_Okay : Compile_Error;
>+        } else {

r=me to fix this else after return in moved code, any time.

/be
Depends on: 693311
You need to log in before you can comment on or make changes to this bug.