690984 - Finish porting Sync tests to use JS sync server (and enhance as appropriate)

Status: RESOLVED INVALID

(Firefox :: Sync, enhancement)

Description

[Richard Newman [:rnewman]]

Follow-on from Bug 673548.

We can also clean up and refactor some of the helpers (e.g., the collection modified tracker).

Comment 1

[Leni Kadali [:leni1] [GMT+3]]

(In reply to Richard Newman [:rnewman] from comment #0)
> Follow-on from Bug 673548.
> 
> We can also clean up and refactor some of the helpers (e.g., the collection
> modified tracker).

Interested in doing the clean up and refactoring of the code. 
Looked at the reference bugs 691643 and 673548. The files I'm to look at are:
services/sync/tests/unit/head_http_server.js 		
services/sync/tests/unit/test_bookmark_engine.js 		
services/sync/tests/unit/test_bookmark_smart_bookmarks.js 		
services/sync/tests/unit/test_clients_engine.js 		
services/sync/tests/unit/test_corrupt_keys.js 		
services/sync/tests/unit/test_engine_abort.js 		
services/sync/tests/unit/test_history_engine.js 	
services/sync/tests/unit/test_hmac_error.js 		
services/sync/tests/unit/test_syncengine_sync.js
services/sync/tests/unit/test_httpd_sync_server.js

So what exactly would I be doing to solve the bug?

Comment 2

[Richard Newman [:rnewman]]

eoger, you were just poking around this part of the codebase… care to take over mentoring this?

Comment 3

[Edouard Oger [:eoger]]

I'm not exactly sure what this bug is about.

Comment 4

[Mark Hammond [:markh] [:mhammond]]

(In reply to Richard Newman [:rnewman] from comment #2)
> eoger, you were just poking around this part of the codebase… care to take
> over mentoring this?

Richard, it seems this isn't really relevant any more - the tests that should be using the test server already seem to be doing so. Should we just close this?

Comment 5

[Richard Newman [:rnewman]]

Yeah, done enough.

Leni, we're going to close this bug; thanks for taking an interest, and apologies for the churn!

Comment 6

[Leni Kadali [:leni1] [GMT+3]]

(In reply to Richard Newman [:rnewman] from comment #5)
> Yeah, done enough.
> 
> Leni, we're going to close this bug; thanks for taking an interest, and
> apologies for the churn!

Well no worries. It got solved, so it's win-win for everyone :)