691021 - Wrong version in DOM Inspector install.rdf for Seamonkey

Status: RESOLVED WORKSFORME

(Other Applications :: DOM Inspector, defect)

Description

[barbara]

Attachment: patch for comm-release/mozilla/extensions/inspector/install.rdf

User Agent: Mozilla/5.0 (X11; FreeBSD i386; rv:7.0.1) Gecko/20111001 Firefox/7.0.1 SeaMonkey/2.4.1
Build ID: 20111001014149

Steps to reproduce:

After upgrading to 2.4, and then to 2.4.1, DOM Inspector is disabled and reported as incompatible with 2.4.1 in Add-ons Manager.



Actual results:

The maxVersion has not been updated
# grep maxVersion.2 comm-release/mozilla/extensions/inspector/install.rdf
        <em:maxVersion>2.4a1</em:maxVersion>



Expected results:

The maxVersion should be updated.

BTW I can see the same in
comm-release/calendar/providers/gdata/install.rdf

Comment 1

[Javi Rueda :javirid]

Hello, Barbara.

I am assuming that DOMi is really compatible with Seamonkey 2.4.1 (or latest version). I don't know if it really is.

Once said that, your patch doesn't look quite good, as it seems to delete one file with .orig extension (possibly you reverted a previous edit) and modifies the install.rdf. Both --- and +++ files should be the same.

In order to avoid this kind of problems, I recommend you to look at https://developer.mozilla.org/en/Mercurial_Queues and then at http://blog.bonardo.net/2010/06/22/so-youre-about-to-use-checkin-needed

Once you are able to attach a new patch, please mark it as "patch" on the form.

Thank you for contributing.

Comment 2

[barbara]

I tried reading the pages that you linked, but think that there is a misunderstanding.
The patch I filed is not a mercurial diff (if that's what you are trying to tell me), it's just the output of diff -u, as you can see here: http://www.freebsd.org/cgi/man.cgi?query=diff&apropos=0&sektion=0&manpath=FreeBSD+8.2-stable&arch=default&format=html 
or here: http://www.gnu.org/s/diffutils/manual/html_node/Unified-Format.html#Unified-Format
I have no access to Seamonkey's repository.

Using the command "patch", the patch is applied and the original file will be backed up with .orig as suffix
es.: patch < patchfile - in this case in the same where directory comm-release is located.

Anyway, I posted the problem about 2 months ago now, and in the meanwhile Seamonkey 2.5 has been released. DOMi is working again as now install.rdf has this line:
    <em:maxVersion>2.7a1</em:maxVersion>

So I think you can close this.

Thanks!

Comment 3

[Javi Rueda :javirid]

-> WORKSFORME because of comment 2