Closed
Bug 691148
Opened 13 years ago
Closed 9 years ago
Remove unused strings from pipnss.properties
Categories
(Core :: Security: PSM, defect)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla38
People
(Reporter: atopal, Assigned: Cykesiopka)
References
Details
Attachments
(1 file, 1 obsolete file)
5.79 KB,
patch
|
Cykesiopka
:
review+
|
Details | Diff | Splinter Review |
Since the era of floppy disks is long gone, please change: security:pipnss.properties:ForcedBackup3 from "To make a copy, click OK. If possible, you should save your backup copy on a floppy disk that you keep in a safe location." To: "To make a copy, click OK. If possible, you should save your backup copy on a flash drive that you keep in a safe location."
Comment 1•13 years ago
|
||
Nit when changing the wording/meaning of a property we need to change its name too. I would suggest ForcedBackup4
Comment 2•12 years ago
|
||
anyone?
Assignee | ||
Comment 3•9 years ago
|
||
Bug 1030963 removed the use of the following: ForcedBackup1 ForcedBackup2 ForcedBackup3 https://hg.mozilla.org/mozilla-central/rev/68499003df5e Bug 326628 I think removed the use of the following, not entirely sure: AddModulePrompt AddModuleName AddModulePath AddModuleSuccess DelModuleBadName DelModuleIntSuccess DelModuleExtSuccess https://hg.mozilla.org/mozilla-central/rev/4414591c887f Bug 970614 removed the following: PKCS12PasswordInvalid https://hg.mozilla.org/mozilla-central/rev/27a5c0d1a55a#l3.98 The rest look like they were never used, but I haven't verified that. I'm going to morph this bug into removing the unused strings.
Assignee: nobody → nobody
Component: Build → Security: PSM
Product: NSS → Core
Summary: Remove reference to floppy disks → Remove unused strings from pipnss.properties
Version: trunk → Trunk
Assignee | ||
Comment 4•9 years ago
|
||
I included this patch as part of this try push: https://tbpl.mozilla.org/?tree=Try&rev=19b106ae2985
Assignee: nobody → cykesiopka.bmo
Status: NEW → ASSIGNED
Attachment #8554115 -
Flags: review?(dkeeler)
Comment on attachment 8554115 [details] [diff] [review] bug681148_rm-unused-pipnss-strings_v1.patch Review of attachment 8554115 [details] [diff] [review]: ----------------------------------------------------------------- Great - thanks.
Attachment #8554115 -
Flags: review?(dkeeler) → review+
Comment hidden (obsolete) |
Assignee | ||
Comment 7•9 years ago
|
||
Oops, wrong bug number in the commit message...
Keywords: checkin-needed
Assignee | ||
Comment 8•9 years ago
|
||
+ Fix bug number in commit message
Attachment #8554115 -
Attachment is obsolete: true
Attachment #8555036 -
Flags: review+
Assignee | ||
Comment 9•9 years ago
|
||
Thanks for the review. (Try link is in Comment 4)
Keywords: checkin-needed
Comment 10•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ed56982ca86d
Keywords: checkin-needed
Comment 11•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ed56982ca86d
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in
before you can comment on or make changes to this bug.
Description
•