Closed Bug 691175 Opened 8 years ago Closed 8 years ago
Unable to back out of Awesome screen
Pressing my devices back button will not back out of the awesome screen; a recent regression. STR: 1. New profile, start Fennec 2. Tap the Awesomebar 3. Tap your devices back button twice ER: Back looking at about:home AR: Stuck in the Awesome screen -- Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111002 Firefox/10.0a1 Fennec/10.0a1 Samsung Galaxy SII Samsung Nexus S
Under the tablet UI, the panel remains open but one can tap outside of it to dismiss it -- Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111003 Firefox/10.0a1 Fennec/10.0a1 Samsung Galaxy Tab 10.1
First known bad: 20111002030844 http://hg.mozilla.org/mozilla-central/rev/90575e23ea93 Last known Good: 20111001030845 http://hg.mozilla.org/mozilla-central/rev/f25928e4847d http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f25928e4847d&tochange=90575e23ea93 Possible culprits? http://hg.mozilla.org/mozilla-central/rev/95b7fab4037c http://hg.mozilla.org/mozilla-central/rev/357f8c513c65 http://hg.mozilla.org/mozilla-central/rev/a89bf0c36977
Regression from bug 684558. Specifically, this broke because I changed the BrowserUI "keypress" handler from capture=true to capture=false.
Version: Trunk → Firefox 10
Attachment #564230 - Flags: review?(mark.finkle)
Comment on attachment 564230 [details] [diff] [review] patch > case "keypress": >+ // Ignore events headed toward the browser; they will be >+ // re-dispatched after content has a chance to handle them. >+ if (aEvent.target == Browser.selectedBrowser) >+ break; I suppose keypresses would only be targeted to the selected browser and not any browser. If we think it could be any browser, maybe use | aEvent.target.localName == "browser" | check instead
Attachment #564230 - Flags: review?(mark.finkle) → review+
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Retested bug with: Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111004 Firefox/10.0a1 Fennec/10.0a1 Devices: Samsung Nexus S (Android 2.3) LG Optimus 2X (Android 2.2) Bug is no longer reproducible. Back button is working properly after Awesome screen is displayed. Verifying bug.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.