Pressing my devices back button will not back out of the awesome screen; a recent regression.
1. New profile, start Fennec
2. Tap the Awesomebar
3. Tap your devices back button twice
ER: Back looking at about:home
AR: Stuck in the Awesome screen
Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111002 Firefox/10.0a1 Fennec/10.0a1
Samsung Galaxy SII
Samsung Nexus S
Under the tablet UI, the panel remains open but one can tap outside of it to dismiss it
Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111003 Firefox/10.0a1 Fennec/10.0a1
Samsung Galaxy Tab 10.1
First known bad:
Last known Good:
Regression from bug 684558. Specifically, this broke because I changed the BrowserUI "keypress" handler from capture=true to capture=false.
Created attachment 564230 [details] [diff] [review]
This fixes the bug, and does not regress bug 684558 or bug 683736.
This also backs out a change I made to browser_awesomescreen.js that I think caught this bug but I thought it was a bug in the test. Oops. :( Tests are passing on desktop except for browser_awesomescreen which is crashing on my desktop build for some unrelated reason (with or without this patch). Pushed to try to test on device:
Comment on attachment 564230 [details] [diff] [review]
> case "keypress":
>+ // Ignore events headed toward the browser; they will be
>+ // re-dispatched after content has a chance to handle them.
>+ if (aEvent.target == Browser.selectedBrowser)
I suppose keypresses would only be targeted to the selected browser and not any browser. If we think it could be any browser, maybe use | aEvent.target.localName == "browser" | check instead
Retested bug with:
Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111004 Firefox/10.0a1 Fennec/10.0a1
Samsung Nexus S (Android 2.3)
LG Optimus 2X (Android 2.2)
Bug is no longer reproducible. Back button is working properly after Awesome screen is displayed.