|
1.07 KB,
patch
|
Justin Lebar (not reading bugmail)
:
review+
asa
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
When I open about:memory?verbose in my build right now, I get a blank page and an XML well-formedness error in the error console. The culprit is this: <span class='mrName hasDesc' title='The sum of all entries below 'shell(javascript:'<html></html>')'.'>shell(javascript:'<html></html>')</span> '<' is not allowed in attribute values in XML. The relevant part of aboutMemory.js is this: 852 var text = "-- <span class='mrName hasDesc' title='" + 853 kindToString(aKind) + prepDesc(aDesc) + 854 "'>" + prepName(aName) + "</span>"; where prepName escapes '&', '<', '>', '\'', and '"' while prepDesc only escapes '&' and '\''. At the very least, prepDesc needs to escape '<'. But is there any reason at all to not use prepName in both places? Not posting a patch for now on the off chance that I'm missing something here...
|
||
Comment 1•6 years ago
|
||
I don't think you're missing something...
|
(Assignee) | |
Comment 2•6 years ago
|
||
Created attachment 564110 [details] [diff] [review] proposed fix I left the separate prepName/prepDesc functions in case we actually want to do more processing on one of them sometime. Let me know if you'd prefer they just be merged.
|
|
(Assignee) | |
Updated•6 years ago
|
||
|
|
||
Comment 3•6 years ago
|
||
Comment on attachment 564110 [details] [diff] [review] proposed fix r=me, but please remove escapeQuotes() -- it's not used, and it sounds like it's not correct under any circumstances!
|
|
(Assignee) | |
Updated•6 years ago
|
||
|
|
(Assignee) | |
Comment 4•6 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/092140ecc44c Justin, do you think we want this on aurora/beta?
|
|
||
Comment 5•6 years ago
|
||
I don't think it's critical to take on aurora/beta, but it would be nice, since if someone has a memory problem and hits this case, we can't get any data out of them.
|
|
(Assignee) | |
Comment 6•6 years ago
|
||
Comment on attachment 564110 [details] [diff] [review] proposed fix Requesting aurora approval. This should be pretty safe, and we need all the memory info we can get. I'm not going to try to get this into beta. Too much risk/reward ratio at that point, I think, if the risk is anything but 0.
|
||
Comment 7•6 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/092140ecc44c
|
||
Updated•6 years ago
|
||
|
|
(Assignee) | |
Comment 8•6 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/6763937c5a1f
|
||
Updated•6 years ago
|
||
Setting resolution to Verified Fixed on: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:9.0) Gecko/20100101 Firefox/9.0 beta 3 Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:10.0a2) Gecko/20111127 Firefox/10.0a2 Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:11.0a1) Gecko/20111127 Firefox/11.0a1 Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:9.0) Gecko/20100101 Firefox/9.0 beta 3 Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:10.0a2) Gecko/20111127 Firefox/10.0a2 Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:11.0a1) Gecko/20111128 Firefox/11.0a1 The about:memory?verbose page is displayed properly.
Description
•