691248 - XUL tree items shouldn't pick up relations from XUL tree

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

They are picked up because tree items and tree accessibles shares the same DOM node.

Comment 1

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 2

[Trevor Saunders (:tbsaunde)]

Comment on attachment 564126 [details] [diff] [review]
patch


>   Relation rel;
>     PRInt32 parentIndex;
>   if (!NS_SUCCEEDED(mTreeView->GetParentIndex(mRow, &parentIndex)))
>     return rel;

return Relation(); ?

It looks like you could move the declaration of rel down if not get rid of it all together and just return Relation(mParent) and Relation(treeAcc.Getblah()) if you want

Comment 3

[alexander :surkov (:asurkov)]

inbound land with Trevor's comment fixed - https://hg.mozilla.org/integration/mozilla-inbound/rev/b963098e5361

Comment 4

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/b963098e5361