691252 - JavaScript strict warning: chrome://browser/content/browser.js, line 6597: reference to undefined property rels.feed

Status: RESOLVED FIXED

(Firefox Graveyard :: RSS Discovery and Preview, defect)

Description

[Richard Newman [:rnewman]]

for (let relVal in rels) {
      switch (relVal) {
        case "feed":
        case "alternate":
          if (!feedAdded) {
            if (!rels.feed && rels.alternate && rels.stylesheet)
              break;

            if (isValidFeed(link, link.ownerDocument.nodePrincipal, rels.feed)) {  <<<<<<< HERE
              FeedHandler.addFeed(link, link.ownerDocument);
              feedAdded = true;
            }
          }
          break;


On current trunk.

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: fix-rel-feed

This has been annoying me for a while.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Looks like browser/base/content/pageinfo/feeds.js needs fixing too?

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1207ad888b05

Fixed the one Gavin found too.

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1207ad888b05