Closed Bug 691252 Opened 12 years ago Closed 10 years ago

JavaScript strict warning: chrome://browser/content/browser.js, line 6597: reference to undefined property rels.feed

Categories

(Firefox Graveyard :: RSS Discovery and Preview, defect)

Product:
Firefox Graveyard
Component:
RSS Discovery and Preview
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 27

People

(Reporter: rnewman, Assigned: billm)

Details

Attachments

(1 file)

fix-rel-feed
983 bytes, patch
Felipe
: review+
Details | Diff | Splinter Review 
for (let relVal in rels) {
      switch (relVal) {
        case "feed":
        case "alternate":
          if (!feedAdded) {
            if (!rels.feed && rels.alternate && rels.stylesheet)
              break;

            if (isValidFeed(link, link.ownerDocument.nodePrincipal, rels.feed)) {  <<<<<<< HERE
              FeedHandler.addFeed(link, link.ownerDocument);
              feedAdded = true;
            }
          }
          break;


On current trunk.
Attached patch fix-rel-feed — — Splinter Review 
This has been annoying me for a while.
Assignee: nobody → wmccloskey
Status: NEW → ASSIGNED
Attachment #811450 - Flags: review?(felipc)
Attachment #811450 - Flags: review?(felipc) → review+
Looks like browser/base/content/pageinfo/feeds.js needs fixing too?
https://hg.mozilla.org/mozilla-central/rev/1207ad888b05
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 27
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.