691377 - crash [@ mozilla::net::CameraStreamImpl::transmitFrame]

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Steffen Wilberg]

https://crash-stats.mozilla.com/report/index/bp-81e1a4ca-d1a3-48bf-b516-4761a2111003

I tried the camera capture demo on http://people.mozilla.org/~fdesre/capture/ with my Samsung Galaxy S (running a leaked build of Android 2.3.4), running the latest Nightly.

Clicking the "capture" button on that site works, it displays a black "Media Upload" box with the live camera preview. But clicking "OK" there crashes Fennec every time.

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

From Socorro : 
https://crash-stats.mozilla.com/report/index/dd022b3d-10de-438b-9ec1-89c182111003

Crashing Thread:
Frame 	Module 	Signature [Expand] 	Source
0 	libxul.so 	mozilla::net::CameraStreamImpl::transmitFrame 	netwerk/protocol/device/CameraStreamImpl.cpp:75
1 	libxul.so 	Java_org_mozilla_gecko_GeckoAppShell_cameraCallbackBridge 	netwerk/protocol/device/CameraStreamImpl.cpp:56
2 	libmozutils.so 	Java_org_mozilla_gecko_GeckoAppShell_cameraCallbackBridge 	other-licenses/android/APKOpen.cpp:243
3 	libdvm.so 	dvmPlatformInvoke 	
4 	libdvm.so 	dvmCallJNIMethod_general 	
5 	dalvik-jit-code-cache (deleted) 	dalvik-jit-code-cache @0x23f 	
6 	libdvm.so 	dexDataMapAlloc 	
7 	libdvm.so 	dvmMterpStd 	
8 	libdvm.so 	dvmInterpret 	
9 	libdvm.so 	dvmInvokeMethod 	
10 	libdvm.so 	dvmFreeDexOrJar 	
11 	libdvm.so 	dvmAsmSisterStart 	
12 	libdvm.so 	dvmMterpStd 	
13 	libdvm.so 	dvmInterpret 	
14 	libdvm.so 	dvmCallMethodV 	
15 	libdvm.so 	JNI_CreateJavaVM 	
16 	libandroid_runtime.so 	libandroid_runtime.so@0x38b28 	
17 	libandroid_runtime.so 	libandroid_runtime.so@0x3a516 	
18 	dalvik-LinearAlloc (deleted) 	dalvik-LinearAlloc @0x72007 	
19 	dalvik-heap (deleted) 	dalvik-heap @0x404ff 	
20 	libcutils.so 	property_get 	
21 	libcutils.so 	set_process_name 	
22 	app_process 	app_process@0xccc 	
23 	app_process 	app_process@0x1027 	
24 	libandroid_runtime.so 	libandroid_runtime.so@0xb8767 	
25 	app_process 	app_process@0xb33 	
26 	app_process 	app_process@0xb33 	
27 	libc.so 	__libc_init 	
28 		@0xffffffe3 	
29 	app_process 	app_process@0x33 	
30 	app_process 	app_process@0xb1f

Comment 2

[[:fabrice] Fabrice Desré]

Attachment: fix

On some devices, the frame callback gets called one more time asynchronously just after we close the camera.

Comment 3

[[:fabrice] Fabrice Desré]

pushed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cab7a4a4f669

Comment 4

[[:fabrice] Fabrice Desré]

Comment on attachment 564610 [details] [diff] [review]
fix

Asking approval for Aurora, since it fixes a crash with no risk.

Comment 5

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/cab7a4a4f669

Comment 6

[[:fabrice] Fabrice Desré]

pushed to aurora:
https://hg.mozilla.org/releases/mozilla-aurora/rev/910f9161b314

Comment 7

[Cristian Nicolae (:xti)]

Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:10.0)Gecko/20111228
Firefox/10.0 Fennec/10.0
Devices: Samsung Galaxy S
OS: Android 2.2