691419 - The command line background graphic should be moved to the devtools directory

Status: RESOLVED FIXED

(DevTools :: General, defect, P2)

Description

[Joe Walker [:jwalker]]

https://bugzilla.mozilla.org/show_bug.cgi?id=656666#c37

Comment 1

[Dave Camp (:dcamp)]

We're doing developer tool prioritization, filter on 'brontozaur'
to ignore the spam.

Comment 2

[Leonard Camacho [:lcamacho]]

this look easy, can I take this bug?

Comment 3

[Dão Gottwald [:dao]]

(In reply to leonard.camacho from comment #2)
> this look easy, can I take this bug?

Yep.

You'll find all references to commandline.png here:
http://mxr.mozilla.org/mozilla-central/search?string=commandline.png

You need to 'hg copy' toolkit/themes/winstripe/global/icons/commandline.png to browser/themes/gnomestripe/devtools/commandline.png, then 'hg move' toolkit/themes/winstripe/global/icons/commandline.png to browser/themes/winstripe/devtools/commandline.png and toolkit/themes/pinstripe/global/icons/commandline.png to browser/themes/pinstripe/devtools/commandline.png.

The commandline.png entries in toolkit/themes/winstripe/global/jar.mn and toolkit/themes/pinstripe/global/jar.mn need to be removed and added to browser/themes/winstripe/jar.mn, browser/themes/pinstripe/jar.mn and browser/themes/gnomestripe/jar.mn.

Finally, change all chrome://global/skin/icons/commandline.png references to chrome://browser/skin/devtools/commandline.png.

Comment 4

[Leonard Camacho [:lcamacho]]

Attachment: patchV1

First try, @dao I dont know who need to review this, can you help me with that?

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 594871 [details] [diff] [review]
patchV1

The code changes look fine, but something seems to be wrong with how you moved or diffed commandline.png. For instance, I see "Binary file browser/themes/gnomestripe/devtools/commandline.png has changed" but no actual data.

Can you try hg diff -g?

Comment 6

[Leonard Camacho [:lcamacho]]

It tells me this about an image

diff --git a/toolkit/themes/winstripe/global/icons/commandline.png b/browser/themes/winstripe/devtools/commandline.png
rename from toolkit/themes/winstripe/global/icons/commandline.png
rename to browser/themes/winstripe/devtools/commandline.png

Comment 7

[Dão Gottwald [:dao]]

This looks better. Could you please generate the full patch with -g and attach it here?

Comment 8

[Leonard Camacho [:lcamacho]]

Attachment: patchV1 generated with hg diff -g

Comment 9

[Dão Gottwald [:dao]]

Comment on attachment 594875 [details] [diff] [review]
patchV1 generated with hg diff -g

I hope this applies the right way (toolkit/themes/pinstripe/global/icons/commandline.png needs to be copied, then moved, the other way around obviously won't work). I'll check this after I got some sleep.

Comment 10

[Dão Gottwald [:dao]]

Comment on attachment 594875 [details] [diff] [review]
patchV1 generated with hg diff -g

Works. Thanks for doing this!

Comment 11

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/d4ca3399f24f

Comment 12

[Marco Bonardo [:mak]]

looks like the file has not been moved?

Comment 13

[Marco Bonardo [:mak]]

or better, for some reason win64 can't find it

Comment 14

[Marco Bonardo [:mak]]

I removed the aero icon from jar.mn, that was a leftover
https://hg.mozilla.org/integration/mozilla-inbound/rev/b6bf0037c91f

Comment 15

[Leonard Camacho [:lcamacho]]

@mak thanks I didn't see that one

Comment 16

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/d4ca3399f24f
https://hg.mozilla.org/mozilla-central/rev/b6bf0037c91f