We're doing developer tool prioritization, filter on 'brontozaur' to ignore the spam.
6 years ago
6 years ago
this look easy, can I take this bug?
(In reply to leonard.camacho from comment #2) > this look easy, can I take this bug? Yep. You'll find all references to commandline.png here: http://mxr.mozilla.org/mozilla-central/search?string=commandline.png You need to 'hg copy' toolkit/themes/winstripe/global/icons/commandline.png to browser/themes/gnomestripe/devtools/commandline.png, then 'hg move' toolkit/themes/winstripe/global/icons/commandline.png to browser/themes/winstripe/devtools/commandline.png and toolkit/themes/pinstripe/global/icons/commandline.png to browser/themes/pinstripe/devtools/commandline.png. The commandline.png entries in toolkit/themes/winstripe/global/jar.mn and toolkit/themes/pinstripe/global/jar.mn need to be removed and added to browser/themes/winstripe/jar.mn, browser/themes/pinstripe/jar.mn and browser/themes/gnomestripe/jar.mn. Finally, change all chrome://global/skin/icons/commandline.png references to chrome://browser/skin/devtools/commandline.png.
Created attachment 594871 [details] [diff] [review] patchV1 First try, @dao I dont know who need to review this, can you help me with that?
Comment on attachment 594871 [details] [diff] [review] patchV1 The code changes look fine, but something seems to be wrong with how you moved or diffed commandline.png. For instance, I see "Binary file browser/themes/gnomestripe/devtools/commandline.png has changed" but no actual data. Can you try hg diff -g?
It tells me this about an image diff --git a/toolkit/themes/winstripe/global/icons/commandline.png b/browser/themes/winstripe/devtools/commandline.png rename from toolkit/themes/winstripe/global/icons/commandline.png rename to browser/themes/winstripe/devtools/commandline.png
This looks better. Could you please generate the full patch with -g and attach it here?
Created attachment 594875 [details] [diff] [review] patchV1 generated with hg diff -g
Comment on attachment 594875 [details] [diff] [review] patchV1 generated with hg diff -g I hope this applies the right way (toolkit/themes/pinstripe/global/icons/commandline.png needs to be copied, then moved, the other way around obviously won't work). I'll check this after I got some sleep.
Comment on attachment 594875 [details] [diff] [review] patchV1 generated with hg diff -g Works. Thanks for doing this!
looks like the file has not been moved?
or better, for some reason win64 can't find it
I removed the aero icon from jar.mn, that was a leftover https://hg.mozilla.org/integration/mozilla-inbound/rev/b6bf0037c91f
@mak thanks I didn't see that one