The command line background graphic should be moved to the devtools directory

RESOLVED FIXED in Firefox 13

Status

P2
normal
RESOLVED FIXED
7 years ago
7 months ago

People

(Reporter: jwalker, Assigned: lcamacho)

Tracking

Trunk
Firefox 13

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=dao][lang=css])

Attachments

(1 attachment, 1 obsolete attachment)

We're doing developer tool prioritization, filter on 'brontozaur'
to ignore the spam.
Priority: -- → P2
Assignee: nobody → jwalker
Blocks: 689605
Priority: P2 → --
Priority: -- → P2
Blocks: 659052
No longer blocks: 689605
Assignee: jwalker → nobody
Whiteboard: [good-first-bug]
No longer blocks: 659052
(Assignee)

Comment 2

7 years ago
this look easy, can I take this bug?
(In reply to leonard.camacho from comment #2)
> this look easy, can I take this bug?

Yep.

You'll find all references to commandline.png here:
http://mxr.mozilla.org/mozilla-central/search?string=commandline.png

You need to 'hg copy' toolkit/themes/winstripe/global/icons/commandline.png to browser/themes/gnomestripe/devtools/commandline.png, then 'hg move' toolkit/themes/winstripe/global/icons/commandline.png to browser/themes/winstripe/devtools/commandline.png and toolkit/themes/pinstripe/global/icons/commandline.png to browser/themes/pinstripe/devtools/commandline.png.

The commandline.png entries in toolkit/themes/winstripe/global/jar.mn and toolkit/themes/pinstripe/global/jar.mn need to be removed and added to browser/themes/winstripe/jar.mn, browser/themes/pinstripe/jar.mn and browser/themes/gnomestripe/jar.mn.

Finally, change all chrome://global/skin/icons/commandline.png references to chrome://browser/skin/devtools/commandline.png.
(Assignee)

Comment 4

7 years ago
Created attachment 594871 [details] [diff] [review]
patchV1

First try, @dao I dont know who need to review this, can you help me with that?
Assignee: nobody → leonard.camacho
Comment on attachment 594871 [details] [diff] [review]
patchV1

The code changes look fine, but something seems to be wrong with how you moved or diffed commandline.png. For instance, I see "Binary file browser/themes/gnomestripe/devtools/commandline.png has changed" but no actual data.

Can you try hg diff -g?
(Assignee)

Comment 6

7 years ago
It tells me this about an image

diff --git a/toolkit/themes/winstripe/global/icons/commandline.png b/browser/themes/winstripe/devtools/commandline.png
rename from toolkit/themes/winstripe/global/icons/commandline.png
rename to browser/themes/winstripe/devtools/commandline.png
This looks better. Could you please generate the full patch with -g and attach it here?
Whiteboard: [good-first-bug] → [good first bug][mentor=dao][lang=css]
(Assignee)

Comment 8

7 years ago
Created attachment 594875 [details] [diff] [review]
patchV1 generated with hg diff -g
Attachment #594871 - Attachment is obsolete: true
Comment on attachment 594875 [details] [diff] [review]
patchV1 generated with hg diff -g

I hope this applies the right way (toolkit/themes/pinstripe/global/icons/commandline.png needs to be copied, then moved, the other way around obviously won't work). I'll check this after I got some sleep.
Attachment #594875 - Flags: review?(dao)
Comment on attachment 594875 [details] [diff] [review]
patchV1 generated with hg diff -g

Works. Thanks for doing this!
Attachment #594875 - Flags: review?(dao) → review+
looks like the file has not been moved?
or better, for some reason win64 can't find it
I removed the aero icon from jar.mn, that was a leftover
https://hg.mozilla.org/integration/mozilla-inbound/rev/b6bf0037c91f
(Assignee)

Comment 15

7 years ago
@mak thanks I didn't see that one

Updated

7 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.