691463 - Kill xpcprivate.h

Status: RESOLVED WONTFIX

(Core :: XPConnect, defect)

Description

[Bobby Holley (:bholley)]

I was tempted to do this as part of my code cleanup in bug 688012 and bug 691411, but I think it can be done separately.

A major part of this is determining what bits of functionality motivate 13 other parts of non-XPConnect gecko code to #include "xpcprivate.h". We should expose those parts explicitly through a public API (probably derived from xpcpublic.h), and then break xpcprivate.h up into smaller chunks.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Stealing; I've got some patches.

Comment 2

[Masatoshi Kimura [:emk]]

I'm even prompted including xpcprivate.h in bug 649133 to call XPCStringConvert::ReadableToJSVal.

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: First batch

Comment 4

[Bobby Holley (:bholley)]

Comment on attachment 589591 [details]
First batch

So, talking to blake this week, it sounds like he'd prefer to just keep removing non-xpc consumers of xpcprivate, moving everything we need to xpcpublic, and otherwise leave xpcprivate as a single file.

Sorry that I led you astray by filing this bug here. :-( How many non-xpc files still include xpcprivate? Are we close to making it truly private?