691567 - Show compatibility warning if an add-on uses taintEnabled

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Compatibility Tools, defect, P2)

Description

[Jorge Villalobos [:jorgev] (he/him)]

As explained in bug 679971, navigator.taintEnabled has been removed. We need to check for all calls of the taintEnabled function and show a compatibility warning.

This is a compatibility warning, so the add-on should still be upgraded in this case.

Message:

The taintEnabled function is no longer available in Firefox 9. Since this function was only used for browser detection and this doesn't belong in extension code, you should remove it if possible. For more information, please see <LINK>.

Link: https://bugzilla.mozilla.org/show_bug.cgi?id=679971

Affected add-on:

https://addons.mozilla.org/en-US/firefox/addon/local-load/

Comment 1

[Allen Short [:ashort]]

Fixed. https://github.com/mozilla/amo-validator/commit/aaab1b0e7b6db2b664d6a6a53ab6172efe9d911b

Comment 2

[krupa raj[:krupa]]

I don't see any warnings while validating for navigator.taintEnabled

See https://addons-dev.allizom.org/en-US/developers/upload/7264a673146f45978320fdf44e9f79d9

Comment 3

[Kumar McMillan [:kumar]]

Krupa / Jorge : this addon, local_load does not use navigator.taintEnabled but it includes mootools.js which does.  I believe that the validator has code to ignore known third party libraries.  Can you find (or create) and addon that uses navigator.taintEnabled directly?

Comment 4

[Allen Short [:ashort]]

A bit of debugging reveals that the validator does in fact skip the mootools files that mention taintEnabled.

Comment 5

[krupa raj[:krupa]]

I used FireClip and it seems to work. See https://addons-dev.allizom.org/en-US/developers/upload/03edcd550aec4abf933dda77e6f22e0b

Moving this back to Resolved.

Comment 6

[Jorge Villalobos [:jorgev] (he/him)]

Hrm. While I don't care too much about this warning, it should mostly occur within library code. I think we'll need to figure out a way to make an exception to the library code rule when doing compat checks.

Comment 7

[Jorge Villalobos [:jorgev] (he/him)]

For the future, that is. I'll file a bug.