Closed
Bug 691646
Opened 11 years ago
Closed 11 years ago
Pattern tile pixelated on patternTransform
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: longsonr, Assigned: longsonr)
References
()
Details
Attachments
(1 file, 2 obsolete files)
3.23 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•11 years ago
|
Assignee | ||
Updated•11 years ago
|
Attachment #564442 -
Flags: review?(dholbert)
Assignee | ||
Updated•11 years ago
|
Attachment #564442 -
Attachment is patch: true
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → longsonr
Assignee | ||
Comment 1•11 years ago
|
||
I've just realised the patch should be fabs(patternMatrix->xx) and fabs(patternMatrix->yy) in case someone has written scale(-40) which should invert the image as well as scaling it. The patch as written would not render scale(-40).
Comment 2•11 years ago
|
||
Comment on attachment 564442 [details] [diff] [review] patch Could you add a reftest for the situation described in comment 1? (with inverting coming into play) r=me with that.
Attachment #564442 -
Flags: review?(dholbert) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Attachment #564442 -
Attachment is obsolete: true
Assignee | ||
Comment 4•11 years ago
|
||
pushed https://hg.mozilla.org/integration/mozilla-inbound/rev/9c7b5bdb4f04
Assignee | ||
Updated•11 years ago
|
Flags: in-testsuite+
Assignee | ||
Comment 5•11 years ago
|
||
And backed out as the reftest fails on Linux.
Assignee | ||
Comment 6•11 years ago
|
||
Attachment #564471 -
Attachment is obsolete: true
Comment 7•11 years ago
|
||
Try run for 696085573f75 is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=696085573f75 Results (out of 9 total builds): success: 4 warnings: 5 Builds available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/longsonr@gmail.com-696085573f75
Comment 8•11 years ago
|
||
Try run for 6b114ae3b4c4 is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=6b114ae3b4c4 Results (out of 9 total builds): success: 9 Builds available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/longsonr@gmail.com-6b114ae3b4c4
Assignee | ||
Comment 9•11 years ago
|
||
fixed reftest and landed as https://hg.mozilla.org/integration/mozilla-inbound/rev/e05e1b35ebed
Updated•11 years ago
|
Whiteboard: [inbound]
Target Milestone: --- → mozilla10
Assignee | ||
Comment 10•11 years ago
|
||
antialiasing sucks when you're writing reftests :-(
Comment 11•11 years ago
|
||
Landing: https://hg.mozilla.org/mozilla-central/rev/9c7b5bdb4f04 Backout: https://hg.mozilla.org/mozilla-central/rev/8dac1be4c4c1
Updated•11 years ago
|
Whiteboard: [inbound]
Comment 12•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e05e1b35ebed
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 13•11 years ago
|
||
Looking back on this, I think we should have used patternMatrix->GetScaleFactors() to get the scale factors, instead of using patternMatrix->xx / patternMatrix->yy. (assuming patternMatrix is non-singular) Otherwise, I think rotations / skews could mess us up here. Robert: am I missing something, or does that make sense? I'm happy to file a followup on that, just wanted to sanity-check here first.
Assignee | ||
Comment 14•11 years ago
|
||
patternMatrix->ScaleFactors(true)
Comment 15•11 years ago
|
||
Yup, sorry for getting the wrong name there. Actually I'm getting less sure about ScaleFactors, though, from looking at the impl... I'm not sure we'd always be able to pass the right value of "xMajor". (the existing code also only has 2 calls to ScaleFactors, with 'true' in both places, but I don't think that's necessarily right in this spot) So, I think I rescind comment 13 (at least partly)... sorry for my confusion on this.
You need to log in
before you can comment on or make changes to this bug.
Description
•