Clean up string resources

RESOLVED FIXED

Status

Mozilla Labs
F1
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: markh, Unassigned)

Tracking

Trunk
x86_64
Windows Vista

Details

Attachments

(1 attachment)

While looking into bug 688893, I noticed lots of string resources which aren't currently used.  I'll attach a pull request that removes the unused ones and also arranges for the f1 button to get a tooltip.
(Reporter)

Comment 1

6 years ago
Created attachment 564454 [details]
Pointer to Github pull request: https://github.com/mozilla/fx-share-addon/pull/20

Pointer to Github pull-request
(Reporter)

Updated

6 years ago
Attachment #564454 - Flags: review?(mixedpuppy)
Comment on attachment 564454 [details]
Pointer to Github pull request: https://github.com/mozilla/fx-share-addon/pull/20

The patch is changing the repositories used in the develop branch, that shouldn't be done.
Attachment #564454 - Flags: review?(mixedpuppy) → review-
It looks like you branched from the release/fx-q3 branch and are merging into develop.  That needs to be fixed (there are other changes leaking back into develop with this merge request)
Comment on attachment 564454 [details]
Pointer to Github pull request: https://github.com/mozilla/fx-share-addon/pull/20

changing my review to +, I was looking at the wrong pull request.  What is pull request 19 for?  It looks fishy.
Attachment #564454 - Flags: review- → review+
pushed https://github.com/mozilla/fx-share-addon/commit/376d0cdfb7148fd8c363beb5e813907f2bf74a93
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.