[Tablet] Optgroup should not have checkbox in select popup helper

VERIFIED FIXED in Firefox 10

Status

Firefox for Android Graveyard
General
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: Martijn Wargers (dead), Assigned: Martijn Wargers (dead))

Tracking

({testcase})

Trunk
Firefox 10
All
Android
testcase
Bug Flags:
in-testsuite -

Details

(URL)

Attachments

(4 attachments, 1 obsolete attachment)

(Assignee)

Description

7 years ago
See testcase https://bugzilla.mozilla.org/attachment.cgi?id=562610
which is from bug 689403.
The second line in the select list is an optgroup element, which can't be selected. The select helper popup shows a checkmark after it, which gives the wrong impression that you are able to select it.
(Assignee)

Comment 1

7 years ago
Created attachment 564553 [details]
testcase

Also, no checkmarks should be there for disabled options.
Assignee: nobody → wjohnston
(Assignee)

Comment 2

7 years ago
The checkmark that I see is from here:
http://mxr.mozilla.org/mozilla-central/source/mobile/themes/core/gingerbread/images/radio-selected-hdpi.png
Weird that it comes from the gingerbread theme.
I'm testing on the EEE Transformer, so I would expect the honeycomb theme.
(Assignee)

Comment 3

7 years ago
Created attachment 564863 [details]
testcase2
(Assignee)

Comment 4

7 years ago
Created attachment 564879 [details]
testcase3
(Assignee)

Comment 5

7 years ago
Created attachment 564882 [details] [diff] [review]
patch

This fixes it for me. Note in the patch that I omitted the ':not([disabled="true"])' part of the rule for the .selected case, because disabled options can be selected, only not by user input.

I can write a browser-chrome test for this, but I first would like to have the browser-chrome test in bug 685197 checked in, before I give it a try.
Attachment #564882 - Flags: review?(wjohnston)
Comment on attachment 564882 [details] [diff] [review]
patch

Review of attachment 564882 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Thanks Martijn!
Attachment #564882 - Flags: review?(wjohnston) → review+
(Assignee)

Comment 7

7 years ago
Created attachment 565654 [details] [diff] [review]
mq diff
Attachment #564882 - Attachment is obsolete: true
(Assignee)

Updated

7 years ago
Assignee: wjohnston → martijn.martijn
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/ff2e14cc772f
Flags: in-testsuite-
Keywords: checkin-needed
OS: Windows 7 → Android
Hardware: x86 → All
Target Milestone: --- → Firefox 10
https://hg.mozilla.org/mozilla-central/rev/ff2e14cc772f
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111011 Firefox/10.0a1 Fennec/10.0a1
Samsung Galaxy SII (2.3.4)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.