Closed Bug 691759 Opened 13 years ago Closed 6 years ago

Possible deadlock in devicemanagerADB.py

Categories

(Testing :: Reftest, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1440714

People

(Reporter: BenWa, Assigned: gbrown)

Details

In devicemanagerADB.py we use |subprocess.Popen(args, stdout=subprocess.PIPE, stderr=subprocess.PIPE)|. This requires us to actively read from the stdout/stderr pipes otherwise they can fill up and cause a deadlock.

Ted suggests:
if we're using stdout=PIPE, then we should probably either a) be using stderr=subprocess.STDOUT to intermingle them, or b) using .communicate
devicemanager has been replaced.
Assignee: nobody → gbrown
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.