Closed Bug 691779 Opened 9 years ago Closed 9 years ago

devicemanagerADB pull interfering with reftest output

Categories

(Testing :: Reftest, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla10

People

(Reporter: BenWa, Assigned: BenWa)

References

Details

Attachments

(1 file)

We currently get output from adb pull mixed in with the reftest output. This output must be removed before using the reftest analyzer. I'm suggesting we silence this output.
Attachment #564563 - Flags: review?(jmaher)
Comment on attachment 564563 [details] [diff] [review]
Silence ADB Pull output

Review of attachment 564563 [details] [diff] [review]:
-----------------------------------------------------------------

I would like to make this optional with a verbose or debug flag.  Since there is nothing like that for ADB, can you please put a comment in this general section similar to:

# TODO: add debug flags and allow for printing stdout
# self.runCmd(["pull", remoteFile, localFile]).stdout.read()
self.runCmd(["pull", remoteFile, localFile])
Attachment #564563 - Flags: review?(jmaher) → review+
oh, also we have a mirrored version of this in the talos tree:
http://hg.mozilla.org/build/talos/file/tip/devicemanagerADB.py

If we don't close this bug until both copies are updated I would be happy :)
https://hg.mozilla.org/integration/mozilla-inbound/rev/c6da52c82202

Inbound will close this bug, we need to remember to reopen.
Assignee: nobody → bgirard
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/c6da52c82202

Leaving open for comment 3 / comment 4.
Target Milestone: --- → mozilla10
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.