Note: There are a few cases of duplicates in user autocompletion which are being worked on.

js::types::TypeSet::add could consolidate calls to js::types::TypeCompartment::resolvePending

RESOLVED FIXED in mozilla10

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jimb, Assigned: jimb)

Tracking

unspecified
mozilla10
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 564680 [details] [diff] [review]
Consolidate calls to TypeCompartment::resolvePending in TypeSet::add

Just meant to be a clarification; if you don't agree, I won't be hurt. :)
Attachment #564680 - Flags: review?(bhackett1024)
(Assignee)

Comment 1

6 years ago
Notes from the patch, meant to put these in the bugzilla comments:

This patch causes no change in behavior; it's meant to clarify the code
that propagates a typeset's member types out to a newly added constraint a
bit:

- Code that queues PendingWork items is segregated from a single
  resolvePending call at the end.

- The type lattice --- TYPE_FLAG_UNKNOWN over everything,
  TYPE_FLAG_ANYOBJECT over all object types --- appears directly in the
  pattern of 'if's and 'else's.
Comment on attachment 564680 [details] [diff] [review]
Consolidate calls to TypeCompartment::resolvePending in TypeSet::add

Nice, this is definitely easier to follow.
Attachment #564680 - Flags: review?(bhackett1024) → review+
(Assignee)

Comment 3

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/e6e18c92ea80
Status: NEW → ASSIGNED
Whiteboard: [inbound]

Comment 4

6 years ago
https://hg.mozilla.org/mozilla-central/rev/e6e18c92ea80
Assignee: general → jimb
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.