Closed
Bug 691934
Opened 13 years ago
Closed 13 years ago
js::types::TypeSet::add could consolidate calls to js::types::TypeCompartment::resolvePending
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: jimb, Assigned: jimb)
Details
(Whiteboard: [inbound])
Attachments
(1 file)
|
2.68 KB,
patch
|
bhackett1024
:
review+
|
Details | Diff | Splinter Review |
Just meant to be a clarification; if you don't agree, I won't be hurt. :)
Attachment #564680 -
Flags: review?(bhackett1024)
|
Assignee | |
Comment 1•13 years ago
|
||
Notes from the patch, meant to put these in the bugzilla comments: This patch causes no change in behavior; it's meant to clarify the code that propagates a typeset's member types out to a newly added constraint a bit: - Code that queues PendingWork items is segregated from a single resolvePending call at the end. - The type lattice --- TYPE_FLAG_UNKNOWN over everything, TYPE_FLAG_ANYOBJECT over all object types --- appears directly in the pattern of 'if's and 'else's.
|
||
Comment 2•13 years ago
|
||
Comment on attachment 564680 [details] [diff] [review] Consolidate calls to TypeCompartment::resolvePending in TypeSet::add Nice, this is definitely easier to follow.
Attachment #564680 -
Flags: review?(bhackett1024) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e6e18c92ea80
Status: NEW → ASSIGNED
Whiteboard: [inbound]
|
||
Comment 4•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e6e18c92ea80
Assignee: general → jimb
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in
before you can comment on or make changes to this bug.
Description
•