Closed Bug 691934 Opened 8 years ago Closed 8 years ago
Set::add could consolidate calls to js::types::Type Compartment::resolve Pending
Just meant to be a clarification; if you don't agree, I won't be hurt. :)
Attachment #564680 - Flags: review?(bhackett1024)
Notes from the patch, meant to put these in the bugzilla comments: This patch causes no change in behavior; it's meant to clarify the code that propagates a typeset's member types out to a newly added constraint a bit: - Code that queues PendingWork items is segregated from a single resolvePending call at the end. - The type lattice --- TYPE_FLAG_UNKNOWN over everything, TYPE_FLAG_ANYOBJECT over all object types --- appears directly in the pattern of 'if's and 'else's.
Comment on attachment 564680 [details] [diff] [review] Consolidate calls to TypeCompartment::resolvePending in TypeSet::add Nice, this is definitely easier to follow.
Attachment #564680 - Flags: review?(bhackett1024) → review+
Status: NEW → ASSIGNED
Assignee: general → jimb
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.