Last Comment Bug 691934 - js::types::TypeSet::add could consolidate calls to js::types::TypeCompartment::resolvePending
: js::types::TypeSet::add could consolidate calls to js::types::TypeCompartment...
Status: RESOLVED FIXED
[inbound]
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: x86_64 Linux
: -- normal (vote)
: mozilla10
Assigned To: Jim Blandy :jimb
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-04 15:03 PDT by Jim Blandy :jimb
Modified: 2011-10-06 03:49 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Consolidate calls to TypeCompartment::resolvePending in TypeSet::add (2.68 KB, patch)
2011-10-04 15:03 PDT, Jim Blandy :jimb
bhackett1024: review+
Details | Diff | Splinter Review

Description Jim Blandy :jimb 2011-10-04 15:03:58 PDT
Created attachment 564680 [details] [diff] [review]
Consolidate calls to TypeCompartment::resolvePending in TypeSet::add

Just meant to be a clarification; if you don't agree, I won't be hurt. :)
Comment 1 Jim Blandy :jimb 2011-10-04 15:06:48 PDT
Notes from the patch, meant to put these in the bugzilla comments:

This patch causes no change in behavior; it's meant to clarify the code
that propagates a typeset's member types out to a newly added constraint a
bit:

- Code that queues PendingWork items is segregated from a single
  resolvePending call at the end.

- The type lattice --- TYPE_FLAG_UNKNOWN over everything,
  TYPE_FLAG_ANYOBJECT over all object types --- appears directly in the
  pattern of 'if's and 'else's.
Comment 2 Brian Hackett (:bhackett) 2011-10-04 15:15:58 PDT
Comment on attachment 564680 [details] [diff] [review]
Consolidate calls to TypeCompartment::resolvePending in TypeSet::add

Nice, this is definitely easier to follow.
Comment 4 Ed Morley [:emorley] 2011-10-06 03:49:36 PDT
https://hg.mozilla.org/mozilla-central/rev/e6e18c92ea80

Note You need to log in before you can comment on or make changes to this bug.