close error notification on success and more standard error attributes to override message

RESOLVED FIXED

Status

Mozilla Labs
OpenWebApps
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: markh, Unassigned)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
When a mediator reports an error the error notification is shown.  If the panel remains open while this error is generated and offers its own retry ui, and that retry succeeds, the error notification is not cleared when the retry is a success.

Also, the error object passed to the callback is currently looking for a ".msg" attribute for an override message.  This should use ".message" to be consistent with other errors.
(Reporter)

Comment 1

7 years ago
Created attachment 564693 [details]
Pointer to Github pull request: https://github.com/mozilla/openwebapps/pull/110

Pointer to Github pull-request
(Reporter)

Updated

7 years ago
Attachment #564693 - Flags: review?(mixedpuppy)
(Reporter)

Updated

7 years ago
OS: Windows Vista → All
Hardware: x86_64 → All
Attachment #564693 - Flags: review?(mixedpuppy) → review+
(Reporter)

Updated

7 years ago
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.