Closed Bug 692196 Opened 8 years ago Closed 8 years ago

Make 'navigator.plugins' have correct info

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Android
defect
Not set

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: snorp, Assigned: snorp)

Details

Attachments

(1 file, 1 obsolete file)

Even with the relevant patches applied to enable Flash support, most websites won't work because they check to see that you have Flash by inspecting 'navigator.plugins'.  We need to make that work.
Attachment #564941 - Flags: review?(blassey.bugs)
Assignee: nobody → snorp
Brad has a patch that takes a different, better, approach. Withdrawing this one.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
What different, better approach? Which patch? Which bug?
Looks like we actually do want this now, reopening.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Comment on attachment 564941 [details] [diff] [review]
Make 'navigator.plugins' have correct content on Android

with this patch and the current front end patch I just get an empty grey box where the plugin should be (no icon, no "Tap here to activate plugin." text).
Attachment #564941 - Attachment is obsolete: true
Attachment #564941 - Flags: review?(blassey.bugs)
Attachment #566597 - Flags: review?(blassey.bugs)
Comment on attachment 566597 [details] [diff] [review]
Make 'navigator.plugins' have correct content on Android

Review of attachment 566597 [details] [diff] [review]:
-----------------------------------------------------------------

this isn't just android code, so someone else should review it. Over to jst.
Attachment #566597 - Flags: review?(blassey.bugs) → review?(jst)
The test failure was due to showing the 'tap to click' UI even when we don't have a valid plugin available. In that case it is supposed to show the alternate content. Working on a fix...
Comment on attachment 566597 [details] [diff] [review]
Make 'navigator.plugins' have correct content on Android

- In nsObjectLoadingContent::OnStartRequest():

+        PluginSupportState pluginState = GetPluginSupportState(thisContent,
+                                                               mContentType);
+        // Do nothing, but fire the plugin not found event if needed
+        if (pluginState != ePluginOtherState) {
+          Fallback(PR_FALSE);
+
+          mFallbackReason = pluginState;
+          FirePluginError(thisContent, pluginState);
+          return NS_BINDING_ABORTED;

Should we not also set mInstantiating to false here in this case? What if the state is ePluginCrashed?
This is e10s only, so not an issue anymore.
Status: REOPENED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → WONTFIX
Attachment #566597 - Flags: review?(jst)
You need to log in before you can comment on or make changes to this bug.