692196 - Make 'navigator.plugins' have correct info

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

Even with the relevant patches applied to enable Flash support, most websites won't work because they check to see that you have Flash by inspecting 'navigator.plugins'.  We need to make that work.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Make 'navigator.plugins' have correct content on Android

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Brad has a patch that takes a different, better, approach. Withdrawing this one.

Comment 3

[Martijn Wargers (dead)]

What different, better approach? Which patch? Which bug?

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

Looks like we actually do want this now, reopening.

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 564941 [details] [diff] [review]
Make 'navigator.plugins' have correct content on Android

with this patch and the current front end patch I just get an empty grey box where the plugin should be (no icon, no "Tap here to activate plugin." text).

Comment 6

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Make 'navigator.plugins' have correct content on Android

Comment 7

[Matt Brubeck (:mbrubeck)]

Landed on inbound but backed out because of test failures:
https://hg.mozilla.org/integration/mozilla-inbound/rev/13342c7d1fc3
https://hg.mozilla.org/integration/mozilla-inbound/rev/2f53f26d9e1b

Comment 8

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 566597 [details] [diff] [review]
Make 'navigator.plugins' have correct content on Android

Review of attachment 566597 [details] [diff] [review]:
-----------------------------------------------------------------

this isn't just android code, so someone else should review it. Over to jst.

Comment 9

[James Willcox (:snorp) ([e-mail]) (he/him)]

The test failure was due to showing the 'tap to click' UI even when we don't have a valid plugin available. In that case it is supposed to show the alternate content. Working on a fix...

Comment 10

[Johnny Stenback (:jst)]

Comment on attachment 566597 [details] [diff] [review]
Make 'navigator.plugins' have correct content on Android

- In nsObjectLoadingContent::OnStartRequest():

+        PluginSupportState pluginState = GetPluginSupportState(thisContent,
+                                                               mContentType);
+        // Do nothing, but fire the plugin not found event if needed
+        if (pluginState != ePluginOtherState) {
+          Fallback(PR_FALSE);
+
+          mFallbackReason = pluginState;
+          FirePluginError(thisContent, pluginState);
+          return NS_BINDING_ABORTED;

Should we not also set mInstantiating to false here in this case? What if the state is ePluginCrashed?

Comment 11

[James Willcox (:snorp) ([e-mail]) (he/him)]

This is e10s only, so not an issue anymore.