6922 - why not cache nsGlobalHistory object?

Status: VERIFIED FIXED

(Core :: XUL, defect, P3)

Description

[Bruce Mitchener]

nsWebShell::GetLinkState() goes to nsServiceManager::GetService() everytime it
is called.  this happens an amazing number of times.  why not cache the
nsGlobalHistory object?

I noticed this because each nsGlobalHistory object was getting stuff out of the
profile and leaking that.  I'll file that separately though.

In a quick run through, there were well over 400 calls to this method.

Comment 1

[Bruce Mitchener]

Filed the leak as bug #6926.

Comment 2

[Chris Waterson]

Well, I think that putting nsIGlobalHistory into the webshell was probably not
a good thing to do. It was easy, but ugly. See

news://news.mozilla.org/3745E325.8DB8EEE4%40netscape.com

I'd like to hash my proposal out on the newsgroup a bit: if it ends up that we
need to keep nsIGlobalHistory in webshell, then this certainly would be a smart
thing to do.

Comment 3

[Chris Waterson]

Okay, Kevin McCluskey fixed this for me, and made the webshell cache the
history service. I still think we should change the way link handling is done,
but that can be dealt with later.