Closed Bug 692236 Opened 8 years ago Closed 8 years ago

Webapps shortcut picker needs a new UI

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Android
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 10

People

(Reporter: sriram, Assigned: sriram)

Details

Attachments

(2 files, 1 obsolete file)

Since it is a picker, it is better to have a picker dialog showing the list of webapps.
Attached patch Patch (obsolete) — Splinter Review
This patch adds a picker dialog showing the list of webapps available.
In case there are no webapps installed, a Toast message is shown, and the activity quits.
This patch also takes care of different themes in gingerbread and honeycomb.
Attachment #564970 - Flags: review?(mark.finkle)
Attached patch PatchSplinter Review
This patch makes it look more like native UI's padding.
The image size has been made constant due to the issue pointed out here: https://bugzilla.mozilla.org/show_bug.cgi?id=692189#c4
Attachment #564970 - Attachment is obsolete: true
Attachment #564970 - Flags: review?(mark.finkle)
Attachment #565061 - Flags: review?(mark.finkle)
Comment on attachment 565061 [details] [diff] [review]
Patch

Nice change. I think this fits in better with the OS too.
Attachment #565061 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mozilla-central/rev/07210340e620
Assignee: nobody → sriram
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 10
Attached patch Follow up patchSplinter Review
I had used "@Override" without need. This has been removed.
Attachment #565667 - Flags: review?(blassey.bugs)
Attachment #565667 - Flags: review?(blassey.bugs) → review+
You need to log in before you can comment on or make changes to this bug.