Closed Bug 692278 Opened 13 years ago Closed 6 years ago

replace skip-if(Android) in manifests with more precise conditions (low memory, ARM cpu, screen size, etc)

Categories

(Testing :: Mozbase, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: k0scist, Unassigned)

References

(Depends on 1 open bug)

Details

(Whiteboard: [mozbase])

we should be more declarative as far as what we put in manifests.

1. a flag (presumedly available from the build) as to whether the
content process is different from the chrome process (which abict is
true on android and not on desktop but that will change soon)

2. abict, android OOMs are currently non-recoverable for Fennec.  So
we want another thingy that obtains system memeory information that
the harness consumes and passes into the expression evaluator so you
can test for that

presumedly these translate into variables that can be used in e.g. skip-if values

See also https://bugzilla.mozilla.org/show_bug.cgi?id=668594#c12
Whiteboard: [mozbase]
This should help with getting the right annotations (and bugs filed) for tests that are failing on android widgets / ARM / e10s / low-ram / slow-cpu
Yep. skip-if(Android) needs to die and be replaced with flags/vars for:

1. e10s content processes
2. Limited VM
3. Slow CPU
4. ARM
5. Android widgets
6. Screen size
7. Window size
8. Fennec frontend
9. Whether the distribution includes the Swedish hyphenation dictionary (!?)

Bug numbers would be good, too.

http://mxr.mozilla.org/mozilla-central/search?string=skip-if%28Android%29
http://mxr.mozilla.org/mozilla-central/search?string=fails-if%28Android%29
would the preference be to have different limits on some things.  Say memory >1gb, >500mb, >256mb, or screen size: height>768, height>1050, height>1200.

it is hard to know exactly what is needed in many tests, so rather than saying memory>628mb, we would pick an arbitrary limit like 512mb or 768mb or 1gb and use that as a benchmark.

as for slow cpu, we might want to have just 2 or 3 standard definitions we use.
Depends on: 732494
Component: ManifestParser → Mozbase
Resummarizing.
Component: Mozbase → General
Summary: be more declarative about manifest conditions → replace skip-if(Android) in manifests with more precise conditions (low memory, ARM cpu, screen size, etc)
Mass closing bugs with no activity in 2+ years. If this bug is important to you, please re-open.
Status: NEW → RESOLVED
Closed: 6 years ago
Component: General → Mozbase
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.