Append PID to cycle collector graph dumps

RESOLVED FIXED in mozilla10

Status

()

Core
XPCOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: azakai, Assigned: azakai)

Tracking

unspecified
mozilla10
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [MemShrink][Inbound])

Attachments

(1 attachment, 1 obsolete attachment)

1.15 KB, patch
dougt
: review+
Details | Diff | Splinter Review
(Assignee)

Description

6 years ago
Created attachment 565045 [details]
linux pid patch

In Fennec and multiprocess Firefox, dumping CC graphs is at risk of the two processes overwriting each other. Appending the PID would solve that.

Attached is a patch that works in Linux. I am not sure what to do in other OSes.
Component: IPC → XPCOM
QA Contact: ipc → xpcom
Whiteboard: [MemShrink]
#include "base/process_util.h"

using namespace base;

snprintf("...%d...", GetCurrentProcId());
(Assignee)

Comment 2

6 years ago
Created attachment 565060 [details] [diff] [review]
patch

Thanks cjones!
Attachment #565045 - Attachment is obsolete: true
Attachment #565060 - Flags: review?(doug.turner)

Updated

6 years ago
Attachment #565060 - Flags: review?(doug.turner) → review+
(Assignee)

Comment 3

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/3b520aebb3fa
Whiteboard: [MemShrink] → [MemShrink][Inbound]
https://hg.mozilla.org/mozilla-central/rev/3b520aebb3fa
Assignee: nobody → azakai
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.