Last Comment Bug 692305 - Append PID to cycle collector graph dumps
: Append PID to cycle collector graph dumps
Status: RESOLVED FIXED
[MemShrink][Inbound]
:
Product: Core
Classification: Components
Component: XPCOM (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla10
Assigned To: Alon Zakai (:azakai)
:
: Nathan Froyd [:froydnj]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-05 15:53 PDT by Alon Zakai (:azakai)
Modified: 2011-10-07 04:11 PDT (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
linux pid patch (628 bytes, text/plain)
2011-10-05 15:53 PDT, Alon Zakai (:azakai)
no flags Details
patch (1.15 KB, patch)
2011-10-05 16:28 PDT, Alon Zakai (:azakai)
doug.turner: review+
Details | Diff | Splinter Review

Description Alon Zakai (:azakai) 2011-10-05 15:53:22 PDT
Created attachment 565045 [details]
linux pid patch

In Fennec and multiprocess Firefox, dumping CC graphs is at risk of the two processes overwriting each other. Appending the PID would solve that.

Attached is a patch that works in Linux. I am not sure what to do in other OSes.
Comment 1 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2011-10-05 16:01:27 PDT
#include "base/process_util.h"

using namespace base;

snprintf("...%d...", GetCurrentProcId());
Comment 2 Alon Zakai (:azakai) 2011-10-05 16:28:07 PDT
Created attachment 565060 [details] [diff] [review]
patch

Thanks cjones!
Comment 4 Ed Morley [:emorley] 2011-10-07 04:11:45 PDT
https://hg.mozilla.org/mozilla-central/rev/3b520aebb3fa

Note You need to log in before you can comment on or make changes to this bug.