Closed Bug 692305 Opened 8 years ago Closed 8 years ago

Append PID to cycle collector graph dumps

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla10

People

(Reporter: azakai, Assigned: azakai)

Details

(Whiteboard: [MemShrink][Inbound])

Attachments

(1 file, 1 obsolete file)

Attached file linux pid patch (obsolete) —
In Fennec and multiprocess Firefox, dumping CC graphs is at risk of the two processes overwriting each other. Appending the PID would solve that.

Attached is a patch that works in Linux. I am not sure what to do in other OSes.
Component: IPC → XPCOM
QA Contact: ipc → xpcom
Whiteboard: [MemShrink]
#include "base/process_util.h"

using namespace base;

snprintf("...%d...", GetCurrentProcId());
Attached patch patchSplinter Review
Thanks cjones!
Attachment #565045 - Attachment is obsolete: true
Attachment #565060 - Flags: review?(doug.turner)
Attachment #565060 - Flags: review?(doug.turner) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/3b520aebb3fa
Whiteboard: [MemShrink] → [MemShrink][Inbound]
https://hg.mozilla.org/mozilla-central/rev/3b520aebb3fa
Assignee: nobody → azakai
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.