Closed
Bug 692341
Opened 13 years ago
Closed 13 years ago
use real webob.Request objects in server-core tests
Categories
(Cloud Services :: Server: Core, enhancement)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rfkelly, Unassigned)
Details
(Whiteboard: [qa-])
Attachments
(1 file, 1 obsolete file)
13.15 KB,
patch
|
telliott
:
review+
|
Details | Diff | Splinter Review |
Currently the server-core testcases use a variety of fake Request objects. This can cause tests to break if internal code starts using methods on the real webob.Request class that aren't provided by the fake.
(e.g. in a new auth handler I want to use request.get_response() to delegate to a repoze.who WSGI app)
Attached patch provides a shortcut for creating a real webob.Request object, and updates the tests to use it.
Attachment #565100 -
Flags: review?(telliott)
Reporter | ||
Comment 1•13 years ago
|
||
Simplifying test_controllers.py to just pass in the environ that it needs
Attachment #565100 -
Attachment is obsolete: true
Attachment #565100 -
Flags: review?(telliott)
Attachment #565104 -
Flags: review?(telliott)
Updated•13 years ago
|
Attachment #565104 -
Flags: review?(telliott) → review+
Reporter | ||
Comment 2•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•13 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•