Closed Bug 692382 Opened 10 years ago Closed 10 years ago

IonMonkey: 10/05 merge has gone awry.

Categories

(Core :: JavaScript Engine, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: sstangl, Assigned: sstangl)

Details

Attachments

(1 file)

Before merge,  2 jit-test failures on x64 --ion-eager.
After merge, 377 jit-test failures on x64 --ion-eager.

I will look into this.
The crashes are in IonActivation::~IonActivation(), when resetting the stack regs.

In the IonActivation constructor, we repointRegs(NULL), and save the old registers.
In the IonActivation destructor, we repointRegs(oldRegs) -- but post-merge, ContextStack::repointRegs() now contains an assertion that regs hasfp(). But we set it to NULL. So we crash.

Since IonActivation knows the new fp, we could just set it in the new FrameRegs, hiding the others.
Still ~110 crashes. Will handle in the morning.
Sorry, that was merge bustage on my part. We removed the assert in Ion and got it back accidentally.

Let's just get it removed on m-c.
Attachment #565387 - Flags: review?(luke)
http://hg.mozilla.org/projects/ionmonkey/rev/3ee51d2222b1

Pushed the above patch to IM branch.
Attachment #565387 - Flags: review?(luke) → review+
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WORKSFORME
Resolution: WORKSFORME → FIXED
You need to log in before you can comment on or make changes to this bug.