692404 - repacker must not update add-ons with modified sdk codebase

Status: RESOLVED DUPLICATE of bug 690824

(addons.mozilla.org Graveyard :: Add-on Builder, defect)

Description

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

See following post from @blackwind on bug 689420

>
> I'm the author of Reload Plus. Just wanted to point out that the version of the
> SDK bundled with my add-on is MODIFIED. I stripped the code that throws the "no > modifiers" exceptions from addon-kit/lib/hotkeys.js and
> api-utils/lib/keyboard/utils.js to work around bug 677785. This is why my
> add-on had its "Upgrade SDK?" flag disabled and why bug 690824 was filed when
> your repacker didn't respect that.
>
> This, though? It's not a bug and can safely be closed.
>

Comment 1

[Daniel Buchner [:dbuc]]

(In reply to Irakli Gozilalishvili [:irakli] [:gozala] from comment #0)
> See following post from @blackwind on bug 689420
> 
> >
> > I'm the author of Reload Plus. Just wanted to point out that the version of the
> > SDK bundled with my add-on is MODIFIED. I stripped the code that throws the "no > modifiers" exceptions from addon-kit/lib/hotkeys.js and
> > api-utils/lib/keyboard/utils.js to work around bug 677785. This is why my
> > add-on had its "Upgrade SDK?" flag disabled and why bug 690824 was filed when
> > your repacker didn't respect that.
> >
> > This, though? It's not a bug and can safely be closed.
> >

We support an "Upgrade SDK" flag? If so, where do we check for the flag so the repacker can skip add-ons that set it to false?

Comment 2

[Myk Melez [:myk] [@mykmelez]]

cc:ing Jeff Balogh, who fixed bug 690824 and might be able to answer dbuc's question in comment 1.

Comment 3

[Jeff Balogh (:jbalogh)]

Now we check for it when looking for all the files that need to be repacked.