Add a hidden pref to disable the script debugger UI

RESOLVED FIXED

Status

()

Firefox
Developer Tools
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: past, Assigned: vporof)

Tracking

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Until the debugger is ready to ship, we should hide it under a hidden pref (devtools.debugger.enabled) from the moment we merge with m-c. This toggle should default to false until it is decided that the debugger is ready for broader testing.
Blocks: 676586
Depends on: 692405

Updated

6 years ago
Blocks: 697762
(Assignee)

Updated

6 years ago
Assignee: nobody → vporof
Status: NEW → ASSIGNED
(Assignee)

Comment 1

6 years ago
Created attachment 572832 [details] [diff] [review]
v1
Attachment #572832 - Flags: review?(past)
(Assignee)

Updated

6 years ago
Attachment #572832 - Flags: feedback?(dcamp)
Looks good, but I'll wait for the modularization patch to apply properly first, so I can test this.
(Assignee)

Comment 3

6 years ago
Created attachment 573326 [details] [diff] [review]
v2
Attachment #572832 - Attachment is obsolete: true
Attachment #572832 - Flags: review?(past)
Attachment #572832 - Flags: feedback?(dcamp)
Attachment #573326 - Flags: review?(past)
Comment on attachment 573326 [details] [diff] [review]
v2

Review of attachment 573326 [details] [diff] [review]:
-----------------------------------------------------------------

Works as advertised!
Attachment #573326 - Flags: review?(past) → review+
I missed that you have kept a default of true, which was not what we intended to do, but now that I think of it, we may want to have people try it on nightlies and give us feedback. Dave what do you think?
(In reply to Panos Astithas [:past] from comment #5)
> I missed that you have kept a default of true, which was not what we
> intended to do, but now that I think of it, we may want to have people try
> it on nightlies and give us feedback. Dave what do you think?

After the recent highlighter incident, it seems prudent to stick to disabled by default, so I did that.
Summary: Add a hidden pref do disable the script debugger UI → Add a hidden pref to disable the script debugger UI
(Assignee)

Comment 7

6 years ago
Agreed.
https://hg.mozilla.org/users/dcamp_campd.org/remote-debug/rev/1ce57902a718
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.