692445 - No language list after tapping on "Change Language" button

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Andreea Pod]

Mozilla /5.0 (Android;Linux armv7l;rv:9.0a1) Gecko/20111004 Firefox/10.0a1 Fennec/10.0a1
Device: LG Optimus 2X

Steps to reproduce:
1. Open Fennec with a new profile
2. Tap on "Change Language" button

Expected result:
the list with all available languages should appear

Actual results:
Preferences panel appears.

Error console:
Error: win.document.getElementById("prefs-languages") is null
Source File: about:home  Line: 161

Comment 1

[Aaron Train [:aaronmt]]

I guess that button should probably call showLocalePicker():

http://mxr.mozilla.org/mozilla-central/source/mobile/chrome/content/preferences.js#155

Comment 2

[Martijn Wargers (dead)]

This came from https://litmus.mozilla.org/show_test.cgi?id=30045

There is no element with id="prefs-languages" at all, it seems.
http://mxr.mozilla.org/mozilla-central/search?string=prefs-languages

Comment 3

[Wesley Johnston (:wesj)]

Attachment: Patch

Nice catch.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

I assume we will want this for Aurora

Comment 5

[Wesley Johnston (:wesj)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/4f241d9a1117

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/mozilla-central/rev/4f241d9a1117

Comment 7

[Aaron Train [:aaronmt]]

(In reply to Mark Finkle (:mfinkle) from comment #4)
> I assume we will want this for Aurora

Aurora (9.0a2) does not have the 'Change Language' button on about:home.

Comment 8

[Aaron Train [:aaronmt]]

Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111011 Firefox/10.0a1 Fennec/10.0a1
Samsung Galaxy SII (2.3.4)