Last Comment Bug 692445 - No language list after tapping on "Change Language" button
: No language list after tapping on "Change Language" button
Status: VERIFIED FIXED
[inbound]
:
Product: Fennec Graveyard
Classification: Graveyard
Component: General (show other bugs)
: Trunk
: ARM Android
: -- normal (vote)
: Firefox 10
Assigned To: Wesley Johnston (:wesj)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-06 08:05 PDT by Andreea Pod
Modified: 2011-10-11 06:37 PDT (History)
10 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Patch (556 bytes, patch)
2011-10-06 09:14 PDT, Wesley Johnston (:wesj)
mark.finkle: review+
Details | Diff | Review

Description Andreea Pod 2011-10-06 08:05:07 PDT
Mozilla /5.0 (Android;Linux armv7l;rv:9.0a1) Gecko/20111004 Firefox/10.0a1 Fennec/10.0a1
Device: LG Optimus 2X

Steps to reproduce:
1. Open Fennec with a new profile
2. Tap on "Change Language" button

Expected result:
the list with all available languages should appear

Actual results:
Preferences panel appears.

Error console:
Error: win.document.getElementById("prefs-languages") is null
Source File: about:home  Line: 161
Comment 1 Aaron Train [:aaronmt] 2011-10-06 08:13:23 PDT
I guess that button should probably call showLocalePicker():

http://mxr.mozilla.org/mozilla-central/source/mobile/chrome/content/preferences.js#155
Comment 2 Martijn Wargers [:mwargers] (not working for Mozilla) 2011-10-06 08:31:00 PDT
This came from https://litmus.mozilla.org/show_test.cgi?id=30045

There is no element with id="prefs-languages" at all, it seems.
http://mxr.mozilla.org/mozilla-central/search?string=prefs-languages
Comment 3 Wesley Johnston (:wesj) 2011-10-06 09:14:11 PDT
Created attachment 565255 [details] [diff] [review]
Patch

Nice catch.
Comment 4 Mark Finkle (:mfinkle) (use needinfo?) 2011-10-06 16:37:22 PDT
I assume we will want this for Aurora
Comment 6 Kyle Huey [:khuey] (khuey@mozilla.com) 2011-10-09 07:28:41 PDT
https://hg.mozilla.org/mozilla-central/rev/4f241d9a1117
Comment 7 Aaron Train [:aaronmt] 2011-10-10 07:42:51 PDT
(In reply to Mark Finkle (:mfinkle) from comment #4)
> I assume we will want this for Aurora

Aurora (9.0a2) does not have the 'Change Language' button on about:home.
Comment 8 Aaron Train [:aaronmt] 2011-10-11 06:37:45 PDT
Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111011 Firefox/10.0a1 Fennec/10.0a1
Samsung Galaxy SII (2.3.4)

Note You need to log in before you can comment on or make changes to this bug.