69245 - Tabs should only change on left click

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Blake Ross]

Index: tabBindings.xml
===================================================================
RCS file: /cvsroot/mozilla/xpfe/global/resources/content/tabBindings.xml,v
retrieving revision 1.11
diff -u -r1.11 tabBindings.xml
--- tabBindings.xml     2001/02/14 20:13:34     1.11
+++ tabBindings.xml     2001/02/18 01:21:53
@@ -157,7 +157,7 @@
       </property>
     </implementation>
     <handlers>
-      <handler event="click">
+      <handler event="click" button="1">
       <![CDATA[
         var tabbox = this.parentNode;
         do {

hewitt, sr?

Comment 1

[timeless]

r=timeless

Comment 2

[John Morrison]

Just a small note: gtk tabbed widgets do process a right click the same way
as a left click (switch panels). 

Comment 3

[Blake Ross]

Hmmm...we don't have platform-specific tab bindings, and I wouldn't want to 
create them over that.  Since most of our other widgets don't trigger on right 
click, I'd prefer to let this be the behavior for all platforms, if that's 
alright with everyone.

Comment 4

[John Morrison]

Yeah, it's a nit. Windows Rules!! :-]

Comment 5

[Matthew T (active 1999-2002)]

Nehhh. Sounds like a bug in GTK to me. It would prevent you from ever giving tabs 
context menus, for example. (Not that I can think of any reason why you might 
want to give tabs context menus ... but I can't think of any reason why you 
shouldn't be able to, either.)

Comment 6

[Joe Hewitt (gone)]

sr=hewitt

Comment 7

[Blake Ross]

checked in.