692496 - Avoid table scan in expiration by restricting on flattened data

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

we can use visit_count or last_visit_date to speed up some expiration query, but those must be reliable (bug 692493).

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

and looks like I also found a bug in annotations expiration while there :(

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: patch v1.0

Speed up some query, and fix the annotation bug (we are expiring timed page annotations when there are no visits, but the page may be a bookmark)

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/efed4eae9cd2

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

backed out due to a failure in a Sync xpcshell test, checking what's up.

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: Sync test patch v1.0

it's a coherence problem in the test itself, it's adding a broken entry to moz_places, but not the corresponding visit. The test looks a bit bogus since next tests are failing on things added by previous tests and there is a strange use of transition_embed (that is actually never added to the database). Btw, to fix this specific case ensuring coherence is enough.

Comment 6

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4bf47794c49c
https://hg.mozilla.org/integration/mozilla-inbound/rev/4bcdbe2fc33b

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/4bf47794c49c
https://hg.mozilla.org/mozilla-central/rev/4bcdbe2fc33b