Closed Bug 692496 Opened 9 years ago Closed 9 years ago

Avoid table scan in expiration by restricting on flattened data

Categories

(Toolkit :: Places, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla10

People

(Reporter: mak, Assigned: mak)

References

Details

Attachments

(2 files)

we can use visit_count or last_visit_date to speed up some expiration query, but those must be reliable (bug 692493).
and looks like I also found a bug in annotations expiration while there :(
Attached patch patch v1.0Splinter Review
Speed up some query, and fix the annotation bug (we are expiring timed page annotations when there are no visits, but the page may be a bookmark)
Attachment #565699 - Flags: review?(dietrich)
Attachment #565699 - Flags: review?(dietrich) → review+
backed out due to a failure in a Sync xpcshell test, checking what's up.
it's a coherence problem in the test itself, it's adding a broken entry to moz_places, but not the corresponding visit. The test looks a bit bogus since next tests are failing on things added by previous tests and there is a strange use of transition_embed (that is actually never added to the database). Btw, to fix this specific case ensuring coherence is enough.
Attachment #565922 - Flags: review?(philipp)
Attachment #565922 - Flags: review?(philipp) → review+
https://hg.mozilla.org/mozilla-central/rev/4bf47794c49c
https://hg.mozilla.org/mozilla-central/rev/4bcdbe2fc33b
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.