typelib.py missing "os" module import

RESOLVED FIXED in Firefox 10

Status

()

Core
XPCOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Todd Whiteman, Assigned: Todd Whiteman)

Tracking

Trunk
mozilla9
Points:
---

Firefox Tracking Flags

(firefox10 fixed)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
On line 288, there is the following code:
    if options.cachedir is not None:
        if not os.path.isdir(options.cachedir):
            os.mkdir(options.cachedir)

but it's missing the "import os" part.

C.f: http://hg.mozilla.org/mozilla-central/file/15bfad783467/xpcom/idl-parser/typelib.py
(Assignee)

Comment 1

6 years ago
Also, relating code is also missing the "import sys" too (see the lines below 288).
(Assignee)

Comment 2

6 years ago
Created attachment 565567 [details] [diff] [review]
Patch to import the missing modules
Attachment #565567 - Flags: review?(khuey)
Comment on attachment 565567 [details] [diff] [review]
Patch to import the missing modules

Which branches do we need this on?
Attachment #565567 - Flags: review?(khuey) → review+
(Assignee)

Comment 4

6 years ago
This would be needed on Mozilla 9.0 and higher, i.e. at present that is the following repos:
* mozilla-aurora
* mozilla-central
Comment on attachment 565567 [details] [diff] [review]
Patch to import the missing modules

Build tool change, 0 risk, unbreaks third parties.
Attachment #565567 - Flags: approval-mozilla-aurora?

Updated

6 years ago
Attachment #565567 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
http://hg.mozilla.org/mozilla-central/rev/1318d1bbc15a
http://hg.mozilla.org/releases/mozilla-aurora/rev/51d973c83798

Thanks for the patch Todd.
Assignee: nobody → toddw
Status: NEW → RESOLVED
Last Resolved: 6 years ago
OS: Linux → All
Hardware: x86_64 → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
Version: unspecified → Trunk
(Assignee)

Updated

6 years ago
status-firefox10: --- → fixed
Marking qa- as this is not something QA needs to verify. Please change to qa+ if this is not the case.
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.