Closed
Bug 692524
Opened 13 years ago
Closed 13 years ago
Run script to modify SDK-based add-on version strings to use new scheme
Categories
(addons.mozilla.org Graveyard :: Maintenance Scripts, defect)
addons.mozilla.org Graveyard
Maintenance Scripts
Tracking
(Not tracked)
RESOLVED
FIXED
6.2.7
People
(Reporter: dbuchner, Assigned: kumar)
Details
Attachments
(2 files)
For all add-ons that have .sdk.1.0 and .sdk.1.1 appended to them, we will need the following actions performed en batch: 1. In the AMO database, replace each add-ons's above mentioned version ending with .1 2. In each add-on's install.rdf, make the same change to the version string present in <em:version>
Reporter | ||
Comment 1•13 years ago
|
||
IMPORTANT: Please do not modify any add-ons that have .sdk.1.0, only the ones that have the version string .sdk.1.1 Let me know if you have any questions.
Updated•13 years ago
|
Assignee: nobody → kumar.mcmillan
Assignee | ||
Comment 2•13 years ago
|
||
Here is the script: https://github.com/jbalogh/zamboni/commit/e9d01c8b68e59a3547ad6266ea1a20d98f6d7bb9 (some fixes came later) We ran this successfully on 159 XPI files on https://addons-dev.allizom.org but we are still verifying the result.
Assignee | ||
Comment 3•13 years ago
|
||
Comment 4•13 years ago
|
||
I tried testing an automatic update from the unrepacked version to the new repacked one for a sample addon (Springpad), but addons-dev.allizom.org doesn't seem to have a "versioncheck" subdomain. Is there another domain to which I can set the URL in extensions.update.url in order to do this test?
Assignee | ||
Comment 5•13 years ago
|
||
Myk, try setting extensions.update_url to https://addons-dev.allizom.org/update/VersionCheck.php?reqVersion=%REQ_VERSION%&id=%ITEM_ID%&version=%ITEM_VERSION%&maxAppVersion=%ITEM_MAXAPPVERSION%&status=%ITEM_STATUS%&appID=%APP_ID%&appVersion=%APP_VERSION%&appOS=%APP_OS%&appABI=%APP_ABI%&locale=%APP_LOCALE%¤tAppVersion=%CURRENT_APP_VERSION%&updateType=%UPDATE_TYPE% Krupa and Daniel were able to get updates successfully. Looks like this is working! Marking as fixed but we can test more before running in production if need be. Note that contrary to the above diff, the script needs to run like: python manage.py fix_jetpack_xpis
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 7•13 years ago
|
||
Can this be run now? We were planning on today. Let me know an ETA for running this on prod.
Comment 8•13 years ago
|
||
Thanks for the script, Kumar! (In reply to Daniel Buchner [:dbuc] from comment #7) > Can this be run now? We were planning on today. Let me know an ETA for > running this on prod. It's going to require a push to prod. Can do Monday morning.
Assignee | ||
Comment 9•13 years ago
|
||
Comment 10•13 years ago
|
||
Are there caches that need updating, and is there any way to get around them for testing purposes? The SpringPad addon is still showing an unmodified version string: https://addons.mozilla.org/en-US/firefox/addon/springpad/
Assignee | ||
Comment 11•13 years ago
|
||
9 out of 170 jetpacks failed when the script ran because their files were disabled: +----------+---------------------------------------------+--------+ | addon_id | filename | status | +----------+---------------------------------------------+--------+ | 337179 | bundlr-1.0.sdk.1.1-fx.xpi | 5 | | 319102 | lokalnewsde_newsticker-0.1b4.sdk.1.1-fx.xpi | 5 | | 337206 | all_add_on_plus-initial.sdk.1.1-fx.xpi | 5 | | 337212 | myhabbana-1.0.rev8.sdk.1.1-fx.xpi | 5 | | 337279 | org-initial.rev6.sdk.1.1-fx.xpi | 5 | | 337232 | roadblocker-1.0.1.sdk.1.1-fx.xpi | 5 | | 337275 | sg_forum_plus-1.1.2.sdk.1.1-fx.xpi | 5 | | 337315 | fallen_galaxy-0.1.1.sdk.1.1-fx.xpi | 5 | | 336732 | fancy_sa_forums-0.1.3.sdk.1.1-fx.xpi | 5 | +----------+---------------------------------------------+--------+ 9 rows in set (0.09 sec) I forgot to filter out disabled files. Status 5 is disabled.
Comment 12•13 years ago
|
||
Thanks Kumar!
Assignee | ||
Comment 13•13 years ago
|
||
(In reply to Myk Melez [:myk] from comment #10) > https://addons.mozilla.org/en-US/firefox/addon/springpad/ This one is showing me the updated version now and when I extracted the XPI I can see the fixed version string in there. I'm not sure how long the install pages are cached for.
Comment 14•13 years ago
|
||
(In reply to Kumar McMillan [:kumar] from comment #13) > (In reply to Myk Melez [:myk] from comment #10) > > https://addons.mozilla.org/en-US/firefox/addon/springpad/ > > This one is showing me the updated version now and when I extracted the XPI > I can see the fixed version string in there. I'm not sure how long the > install pages are cached for. What link is the download button pointing you to? I'm still seeing the cached page, which points to: https://releases.mozilla.org/pub/mozilla.org/addons/309947/springpad-2.3.1106.29.sdk.1.1-fx.xpi The version page <https://addons.mozilla.org/en-US/firefox/addon/springpad/versions/> has been updated with an entry for the modified version, however, and it points to: https://addons.mozilla.org/firefox/downloads/file/133100/springpad-2.3.1106.29.sdk.1.1-fx.xpi?src=version-history Nevertheless, both those XPIs are only 1057 bytes long, and they contain only one file, install.rdf, which does contain the modified version string, but that's little consolation given the lack of any other files in the XPI.
Comment 15•13 years ago
|
||
(In reply to Myk Melez [:myk] from comment #14) > What link is the download button pointing you to? I'm still seeing the > cached page, which points to: > > https://releases.mozilla.org/pub/mozilla.org/addons/309947/springpad-2.3. > 1106.29.sdk.1.1-fx.xpi Or rather I should say that it points to: https://addons.mozilla.org/firefox/downloads/latest/309947/addon-309947-latest.xpi?src=dp-btn-primary Which then goes through several redirects to get to that releases.mozilla.org address, just as the URL on the versions page redirects to a releases.mozilla.org address. The complete set of redirects from the main page for the addon is: https://addons.mozilla.org/firefox/downloads/latest/309947/addon-309947-latest.xpi?src=dp-btn-primary https://addons.mozilla.org/firefox/downloads/latest/springpad/addon-springpad-latest.xpi?src=dp-btn-primary https://addons.mozilla.org/firefox/downloads/file/133100/springpad-2.3.1106.29.sdk.1.1-fx.xpi?src=dp-btn-primary http://releases.mozilla.org/pub/mozilla.org/addons/309947/springpad-2.3.1106.29.sdk.1.1-fx.xpi From the versions page, it's: https://addons.mozilla.org/firefox/downloads/file/133100/springpad-2.3.1106.29.sdk.1.1-fx.xpi?src=version-history http://releases.mozilla.org/pub/mozilla.org/addons/309947/springpad-2.3.1106.29.sdk.1.1-fx.xpi So they both end up at the same URL, which references a XPI that contains nothing but install.rdf.
Reporter | ||
Comment 16•13 years ago
|
||
I have been looking at this extension and the various versions. For some reason the XPI swap script did not function properly in some cases. On some add-ons the script worked just fine, The PNG Project for example: https://addons.mozilla.org/en-US/firefox/addon/the-png-project/versions/ I am investigating this right now with Wil and Kumar.
Updated•8 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•