692536 - Don't fire mousemove events when touchevents call preventDefault

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

Attachment: Patch

We currently throw a mousemove event after a small timeout in input.js. If the page prevented mouse events by calling preventDefault on touchstart, we should also prevent sending this mousemove.

Comment 1

[Wesley Johnston (:wesj)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/733ab06d6e09

Comment 2

[Wesley Johnston (:wesj)]

backed out for bc bustage
https://hg.mozilla.org/integration/mozilla-inbound/rev/e27c6941c340

Comment 3

[Matt Brubeck (:mbrubeck)]

(In reply to Wesley Johnston (:wesj) from comment #2)
> backed out for bc bustage
> https://hg.mozilla.org/integration/mozilla-inbound/rev/e27c6941c340

How confident are you that this caused the b-c failure?  After some re-triggers, we have seven browser-chrome tests runs that include this patch, and the failure occurred in only one of them.  It might just be a new random failure we haven't seen before.  It seems very unlikely that this patch could cause that test to fail.

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/mozilla-central/rev/733ab06d6e09

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

And this got backed out https://hg.mozilla.org/mozilla-central/rev/e27c6941c340

Comment 6

[Martijn Wargers (dead)]

Should this be checked in again? This is not anymore in inbound, is it?

Comment 7

[Wesley Johnston (:wesj)]

I just pushed this back to try. I'll kick off a couple b-c runs there and see if we can tickle this. If not, I'll just land it again.

Comment 8

[Mozilla RelEng Bot]

Try run for 947f2489947f is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=947f2489947f
Results (out of 9 total builds):
    exception: 1
    success: 7
    failure: 1
Builds available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-947f2489947f

Comment 9

[Matt Brubeck (:mbrubeck)]

The browser_awesomescreen.js failures happened again after this bug was backed out, so I think it's definitely off the hook.  Filed bug 693524 for the test failures.

Comment 10

[Wesley Johnston (:wesj)]

I ran browser-chrome 7 times too, and didn't ever see that failure. Pushed again:

http://hg.mozilla.org/integration/mozilla-inbound/rev/e04740676c11

Comment 11

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/mozilla-central/rev/e04740676c11