692629 - IndexedDB: Support IDBObjectStore/IDBIndex.count

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Takes a keyrange or a value

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1.1

Better index query.

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 571059 [details] [diff] [review]
Patch, v1.1

Review of attachment 571059 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

::: dom/indexedDB/IDBIndex.cpp
@@ +1456,5 @@
> +  NS_NAMED_LITERAL_CSTRING(id, "id");
> +
> +  nsCString query = NS_LITERAL_CSTRING("SELECT count(*) FROM ") + table +
> +                    NS_LITERAL_CSTRING(" WHERE index_id = :") + id +
> +                    keyRangeClause;

Why not make the middle line:

NS_LITERAL_CSTRING(" WHERE index_id = :id") +

::: dom/indexedDB/IDBObjectStore.cpp
@@ +2402,5 @@
> +  }
> +
> +  nsCString query = NS_LITERAL_CSTRING("SELECT count(*) FROM ") + table +
> +                    NS_LITERAL_CSTRING(" WHERE object_store_id = :") + osid +
> +                    keyRangeClause;

Same here

Comment 4

[Ed Morley [:emorley]]

Landing on inbound in:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b5c0bfd03fcf

Backed out for failing to build on any platform:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=5675bf2c7930

https://hg.mozilla.org/integration/mozilla-inbound/rev/72042cd154b9

Comment 5

[Ben Turner (not reading bugmail, use the needinfo flag!)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/776dc60cee13

Comment 6

[Ben Turner (not reading bugmail, use the needinfo flag!)]

(In reply to Jonas Sicking (:sicking) from comment #3)
> Why not make the middle line:
> 
> NS_LITERAL_CSTRING(" WHERE index_id = :id") +

It's to avoid making more string data. We do the same all over indexeddb code.

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/776dc60cee13

Comment 8

[Jean-Yves Perrier [:teoli]]

I'm in the process of documenting this change. If I understand well both the code and the spec (and its history), right now (i.e. in Firefox 10), the two new methods implemented by this bug raise IDBDatabaseException and not yet raw DOMException as in the spec. The change in exception will come in the future in bug 693061.

Is this correct?

Comment 9

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Yes, that's correct.

Comment 10

[Jean-Yves Perrier [:teoli]]

Thank you.

Grendel already updated 
https://developer.mozilla.org/en/IndexedDB/IDBIndex#count

I updated:
https://developer.mozilla.org/en/IndexedDB/IDBObjectStore#count

and of course:
https://developer.mozilla.org/en/Firefox_10_for_developers