692676 - highlight required single-select fields on enter_bug

Status: NEW

(Bugzilla :: Creating/Changing Bugs, defect, P3)

Description

[Albert Ting]

Bug 204106 was really helpful, but I'd like it to also address single-select fields.  In my case, I want to force the user to specify a value.  If they choose the default value of "---", then flag a warning in the same way as Bug 204106 handles the other fields.

I believe the changes are minor.  Something like changing js/field.js to call _errorFor for any fields that has been marked mandatory and the submitted value set to "---".  bug/field.html.tmpl would require a minor tweak make single-select also aria-required.

Comment 1

[Max Kanat-Alexander]

Ah, are you looking for UI highlighting, or for JS error checking? I think those would be separate bugs. It would be nice to have both, though.

Comment 2

[Albert Ting]

I've done both.  

UI highlighting is fairly trivial, just a change in bug/field.html.tmpl.  For JS error checking, I'm currently hardcoding the check.  Generalizing would probably mean treating the default value is "invalid".  We'd also need to generalize the error message in global/header.html.

In addition, there should be a way to set the is_mandatory field for builtin fields.  In my case, I manually set the is_mandatory field for bug_severity.  I guess that makes it three tickets... :)