XRE_SendTestShellCommand returns NS_ERROR_FAILURE

RESOLVED FIXED in mozilla10

Status

()

Toolkit
General
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: m_kato, Assigned: m_kato)

Tracking

Trunk
mozilla10
x86
Windows Vista
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment)

fix
902 bytes, patch
Benjamin Smedberg
: review+
Details | Diff | Splinter Review
(Assignee)

Description

7 years ago
return type of XRE_SendTestShellCommand is bool, but it may return NS_ERROR_FAILURE.  (bool)NS_ERROR_FAILURE means true.


https://tbpl.mozilla.org/php/getParsedLog.php?id=6708442&tree=Firefox
d:/mozilla-build/python25/python2.5.exe -O e:/builds/moz2_slave/m-cen-w32/build/build/cl.py cl -FonsEmbedFunctions.obj -c -D_HAS_EXCEPTIONS=0 -I../../dist/stl_wrappers  -DIMPL_XREAPI -DMOZ_APP_NAME='"firefox"' -DMOZ_UPDATER -DWIN32_LEAN_AND_MEAN -DUNICODE -D_UNICODE -DMOZILLA_INTERNAL_API -D_IMPL_NS_COM -DEXPORT_XPT_API -DEXPORT_XPTC_API -D_IMPL_NS_GFX -D_IMPL_NS_WIDGET -DIMPL_XREAPI -DIMPL_NS_NET -DIMPL_THEBES  -DOSTYPE=\"WINNT5.2\" -DOSARCH=WINNT -DEXCLUDE_SKIA_DEPENDENCIES  -DUNICODE -D_UNICODE -DNOMINMAX -D_CRT_RAND_S -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -D_SECURE_ATL -DCHROMIUM_BUILD -DU_STATIC_IMPLEMENTATION -DOS_WIN=1 -DWIN32 -D_WIN32 -D_WINDOWS -DWIN32_LEAN_AND_MEAN  -DCOMPILER_MSVC -DOS_TARGET=\"WINNT\" -DMOZ_WIDGET_TOOLKIT=\"windows\" -DTARGET_XPCOM_ABI=\"x86-msvc\" -DTARGET_OS_ABI=\"WINNT_x86-msvc\"  -DTOOLKIT_EM_VERSION=\"10.0a1\" -DGRE_MILESTONE=10.0a1 -DGRE_BUILDID=20111006101700 -I/e/builds/moz2_slave/m-cen-w32/build/ipc/chromium/src -I/e/builds/moz2_slave/m-cen-w32/build/ipc/glue -I../../ipc/ipdl/_ipdlheaders  -I/e/builds/moz2_slave/m-cen-w32/build/dom/ipc -I/e/builds/moz2_slave/m-cen-w32/build/toolkit/crashreporter -I/e/builds/moz2_slave/m-cen-w32/build/dom/base -I/e/builds/moz2_slave/m-cen-w32/build/xpcom/build  -I/e/builds/moz2_slave/m-cen-w32/build/toolkit/xre -I/e/builds/moz2_slave/m-cen-w32/build/toolkit/xre/../profile -I/e/builds/moz2_slave/m-cen-w32/build/config  -I/e/builds/moz2_slave/m-cen-w32/build/toolkit/xre -I. -I../../dist/include -I../../dist/include/nsprpub  -Ie:/builds/moz2_slave/m-cen-w32/build/obj-firefox/dist/include/nspr -Ie:/builds/moz2_slave/m-cen-w32/build/obj-firefox/dist/include/nss        -TP -nologo -W3 -Gy -Fdgenerated.pdb -wd4800 -we4553  -DNDEBUG -DTRIMMED -Zi -Zi -UDEBUG -DNDEBUG -O1 -Oy    -MD            -FI ../../dist/include/mozilla-config.h -DMOZILLA_CLIENT /e/builds/moz2_slave/m-cen-w32/build/toolkit/xre/nsEmbedFunctions.cpp

e:/builds/moz2_slave/m-cen-w32/build/toolkit/xre/nsEmbedFunctions.cpp(740) : warning C4305: 'return' : truncation from 'nsresult' to 'bool'
(Assignee)

Comment 1

7 years ago
Created attachment 566751 [details] [diff] [review]
fix
Assignee: nobody → m_kato
Attachment #566751 - Flags: review?(benjamin)

Updated

7 years ago
Attachment #566751 - Flags: review?(benjamin) → review+

Comment 3

7 years ago
https://hg.mozilla.org/mozilla-central/rev/411c5d481dc1
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.