692695 - Sync 1.1 API violation: DELETE .../storage returns "true", should return timestamp

Status: RESOLVED FIXED

(Cloud Services Graveyard :: Server: Sync, defect)

Description

[Philipp von Weitershausen [:philikon]]

Quoting http://docs.services.mozilla.com/storage/apis-1.1.html:
>
>  DELETE https://server/pathname/version/username/storage
>
>    Deletes all records for the user. Will return a precondition error unless
>    an X-Confirm-Delete header is included.
>
>    All delete requests return the timestamp of the action.

But:

  Components.utils.import("resource://services-sync/main.js");
  var resource = new Weave.Resource(Weave.Service.storageURL);
  resource.setHeader("X-Confirm-Delete", "1");
  var response = resource.delete();
  response.toString();

returns "true", as is evident from the server-storage code:

    def delete_storage(self, request):
        ...
        return json_response(True)

Comment 1

[Toby Elliott [:telliott]]

Can confirm. PHP code returned server timestamp, so it's a porting error.

Comment 2

[Toby Elliott [:telliott]]

Attachment: Returns the timestamp on a delete call rather than true

Comment 3

[Tarek Ziadé (:tarek)]

Comment on attachment 566073 [details] [diff] [review]
Returns the timestamp on a delete call rather than true

Looks good - there's an extra empty parasite line in the patch

Comment 4

[Toby Elliott [:telliott]]

Fixed in http://hg.mozilla.org/services/server-storage/rev/6b56d4d227b0