Closed Bug 692727 Opened 9 years ago Closed 8 years ago

include non-English hyphenation support on Android

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Android
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 11

People

(Reporter: jfkthame, Assigned: jfkthame)

Details

Attachments

(1 file)

In bug 672320, hyphenation support for a number of non-English languages was added to Firefox. However, the additional resources were omitted from the Android package because of the impact on first-run startup time of unpacking all the dictionary files from the APK into the filesystem.

Now that bug 655337 has landed, however, hyphenation files can be found and loaded directly from the omnijar/APK file, without the need to extract them to the device filesystem. Therefore, additional resources should have no impact on first-run (or subsequent startup) time.

Accordingly, we should include the same collection of resources in the Android package as we have in the desktop products, to provide consistent support for this feature for users (and web authors) across all device types.
We should of course watch for any Ts regression this may cause, but I don't expect one - we no longer unpack the files, and we only load them on demand (when a page specifically requests auto-hyphenation in the relevant language).
Attachment #565473 - Flags: review?(mark.finkle)
Comment on attachment 565473 [details] [diff] [review]
patch, include non-English hyphenation files on Android

OK. Let's try this out and see how it affects XUL Fennec and Native Fennec.
Attachment #565473 - Flags: review?(mark.finkle) → review+
Pushed to inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6bf33945aa28
Assignee: nobody → jfkthame
Target Milestone: --- → Firefox 11
https://hg.mozilla.org/mozilla-central/rev/6bf33945aa28
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.