692783 - Attendees not aligned with their respective free/busy timelines

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[Tristan Miller]

Attachment: Screenshot showing attendee/timeline misalignment

The "Invite Attendees" dialog contains on the left a list of attendees, and on the right a timeline for each attendee showing their free/busy status.  However, as can be seen in the attached screenshot, the height of the rows in the attendee list is greater than the height of the rows in the timeline, resulting in a misalignment of the two lists.  After more than about a half dozen attendees it becomes difficult or impossible to find their corresponding free/busy information, except by laboriously counting rows starting from the top.

I am using Thunderbird 7.0.1 (installed from the official x86-64 binaries) and Lightning 1.0b7 on Ubuntu 10.04.

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Richard, Decathlon, maybe this bug is something for you?

Comment 2

[Richard Marti (:Paenglab)]

Attachment: Fix the min-height

I see this issue also with small fonts. Then the freebusy-grid's addressingWidgetItem is 1px less tall than the Attendee list's addressingWidgetItem. This patch adds this missing px.

Comment 3

[Decathlon]

Attachment: White line appears with small font

I can reproduce the issue on Win7 only when I set a small font (e.g. Segoe UI 8pt). With the standard font (9pt) and bigger fonts the misalignment doesn't appear.

The patch fixes the misalignment problem but, with the small font, a withe line appears in the grid (see screenshot).

At first glance a 
 min-height: 16px;
in the .freebusy-grid class fixes the problem, but I didn't look deeply in the issue. Richard, could you please double check?

Comment 4

[Richard Marti (:Paenglab)]

Attachment: Fix the min-height v2

I think this approach is better and it fixes also the white lines problem with small fonts

Comment 5

[Decathlon]

Comment on attachment 568766 [details] [diff] [review]
Fix the min-height v2

Oh, right. Perfect! :-)

r+

Comment 6

[Richard Marti (:Paenglab)]

Pushed to comm-central http://hg.mozilla.org/comm-central/rev/1eacd7078a20

Comment 7

[Richard Marti (:Paenglab)]

Pushed to comm-aurora http://hg.mozilla.org/releases/comm-aurora/rev/a1eee289974e

Pushed to comm-beta http://hg.mozilla.org/releases/comm-beta/rev/2b77c4840ab0

Comment 8

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Btw, what happens with a really large font? Do the grid lines expand?

Comment 9

[Richard Marti (:Paenglab)]

Yes it expands. Only the min-height was the problem. I tried it with 24px fonts and it worked (and my screen was filled with the list).