Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Firebug should be able to suppress web console prompted by scratchpad

RESOLVED FIXED in Firefox 12

Status

()

Firefox
Developer Tools
P3
normal
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Honza, Assigned: msucan)

Tracking

({qawanted})

Trunk
Firefox 12
x86
Windows Vista
qawanted
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [needs-testing])

Attachments

(1 attachment)

When there is an error in Scratchpad, the build-in console pop-up.

Firebug (or any other dev tool/Console) should be able to register itself as the default Console.

Thoughts?

Honza
(Assignee)

Comment 1

6 years ago
Created attachment 565551 [details] [diff] [review]
proposed patch

My thoughts in the shape of a quick patch. All tests pass.

Honza: You have here what you need: you can override the opening of the Web Console from Scratchpad, and you can override the context menu element inspection menu item. Firebug can change the chromeWindow.Devtools.* methods as needed. Add prefs to allow default tools to work.

Please note this is a quick patch! for fancier stuff, we can open separate bugs, for other features. I think this is a good start - better than to have two "Inspect element" menu items.

Comments welcome!
Assignee: nobody → mihai.sucan
Status: NEW → ASSIGNED
Attachment #565551 - Flags: feedback?(rcampbell)
(In reply to Mihai Sucan [:msucan] from comment #1)
> Honza: You have here what you need: you can override the opening of the Web
> Console from Scratchpad, and you can override the context menu element
> inspection menu item. Firebug can change the chromeWindow.Devtools.* methods
> as needed. Add prefs to allow default tools to work.
Yep I have tested the patch and works for me.

> Please note this is a quick patch! for fancier stuff, we can open separate
> bugs, for other features. I think this is a good start - better than to have
> two "Inspect element" menu items.
Exactly

Just one question, I am not sure what are the rules here, but wouldn't the Devtools related code (and so, even e.g. the Scratchpad object) deserve to be in another file? (while still accessible from browser.xul scope) The browser.js is already pretty huge pile of code.

Honza
(Assignee)

Comment 3

6 years ago
(In reply to Jan Honza Odvarko from comment #2)
> (In reply to Mihai Sucan [:msucan] from comment #1)
> > Honza: You have here what you need: you can override the opening of the Web
> > Console from Scratchpad, and you can override the context menu element
> > inspection menu item. Firebug can change the chromeWindow.Devtools.* methods
> > as needed. Add prefs to allow default tools to work.
> Yep I have tested the patch and works for me.

Great!

> > Please note this is a quick patch! for fancier stuff, we can open separate
> > bugs, for other features. I think this is a good start - better than to have
> > two "Inspect element" menu items.
> Exactly
> 
> Just one question, I am not sure what are the rules here, but wouldn't the
> Devtools related code (and so, even e.g. the Scratchpad object) deserve to
> be in another file? (while still accessible from browser.xul scope) The
> browser.js is already pretty huge pile of code.

That's really up to the browser peer reviewing the patch. It makes sense to, some day, move our browser.js devtools code into a browser-devtools.js that would be #included at the top of browser.js.

Worth filing a follow up bug report?
we need to retest this on nightly to see if the recent fix for the Error messages in Scratchpad bug 690552.
Keywords: qawanted
Priority: -- → P3
Whiteboard: [needs-testing]
(In reply to Rob Campbell [:rc] (robcee) from comment #4)
> we need to retest this on nightly to see if the recent fix for the Error
> messages in Scratchpad bug 690552.

Tested the exception throwing mechanism with the latest Nightly and its a pass. 

Tested all major exceptions to be thrown correctly (syntax errors, illegal statements) in Scratchpad. 

From the Qa side you guys have a green light for closing the bug
Awesome, thank you!
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Depends on: 690552
Target Milestone: --- → Firefox 12
Comment on attachment 565551 [details] [diff] [review]
proposed patch

cancelling feedback request, no longer needed.
Attachment #565551 - Flags: feedback?(rcampbell)
You need to log in before you can comment on or make changes to this bug.