692811 - Fennecbench zoom is broken in tablet mode

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Matt Brubeck (:mbrubeck)]

The Fennecmark zoom.js code starts double-tapping at the top left of the window, and moves to the bottom right:
http://hg.mozilla.org/users/tglek_mozilla.com/fennecmark/file/bfc910cd8dd3/content/zoom.js#l9

But now that we have a sidebar always visible on large-screen devices including the Tegras (bug 677669), some of these taps fall on the sidebar and do nothing.  This gets even worse when we want to do things like open new tabs when double-tapping in the sidebar (bug 660887), which breaks the benchmark completely.

Comment 1

[Matt Brubeck (:mbrubeck)]

Attachment: patch

This patch confines the double-taps to happen within the web content area.

I expect this patch to change Tzoom results when it lands, but it should reduce  the frequency with which changes to the Fennec chrome layout affect future Tzoom results.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 565565 [details] [diff] [review]
patch

Review of attachment 565565 [details] [diff] [review]:
-----------------------------------------------------------------

thanks!

Comment 3

[Matt Brubeck (:mbrubeck)]

http://hg.mozilla.org/users/tglek_mozilla.com/fennecmark/rev/82fd93e056ba