nsIEntropyCollector and nsIScriptChannel interfaces missing in build due to overwriting dom.xpt from plugins

RESOLVED FIXED in mozilla10

Status

()

Core
DOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Mook (work), Assigned: Mook (work))

Tracking

Trunk
mozilla10
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
http://mxr.mozilla.org/mozilla-central/source/dom/dom-config.mk?mark=1-1&rev=bd1411e362fb sets MODULE=dom which overrides http://mxr.mozilla.org/mozilla-central/source/dom/plugins/base/Makefile.in?rev=15bfad783467&mark=45#37 causing it to overwrite dom.xpt from http://mxr.mozilla.org/mozilla-central/source/dom/base/Makefile.in?rev=15bfad783467&mark=45-45#37 .

Found this because I had silly code walking all interfaces and didn't deal with failure correctly.  It failed looking at nsIBufEntropyCollector because the parent interface failed to resolve.

Will attach a patch in a second, I need a bug number for the proper commit message first :)
(Assignee)

Comment 1

6 years ago
Created attachment 565566 [details] [diff] [review]
remove incorrect MODULE= line from dom-config.mk
Assignee: nobody → marky
Attachment #565566 - Flags: review?(benjamin)
Attachment #565566 - Flags: review?(benjamin) → review+

Comment 2

6 years ago
Pushed to mozilla-inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/d2241309d83c

(This was also pushed to try, https://hg.mozilla.org/try/rev/afccba9817a4, linux64 debug+release only, both green)

This is fine to close on inbound->m-c merge.
Flags: in-testsuite-
Target Milestone: --- → mozilla10
https://hg.mozilla.org/mozilla-central/rev/d2241309d83c
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.