Closed
Bug 692826
Opened 13 years ago
Closed 13 years ago
nsIEntropyCollector and nsIScriptChannel interfaces missing in build due to overwriting dom.xpt from plugins
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: mark.yen, Assigned: mark.yen)
References
()
Details
Attachments
(1 file)
504 bytes,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
http://mxr.mozilla.org/mozilla-central/source/dom/dom-config.mk?mark=1-1&rev=bd1411e362fb sets MODULE=dom which overrides http://mxr.mozilla.org/mozilla-central/source/dom/plugins/base/Makefile.in?rev=15bfad783467&mark=45#37 causing it to overwrite dom.xpt from http://mxr.mozilla.org/mozilla-central/source/dom/base/Makefile.in?rev=15bfad783467&mark=45-45#37 . Found this because I had silly code walking all interfaces and didn't deal with failure correctly. It failed looking at nsIBufEntropyCollector because the parent interface failed to resolve. Will attach a patch in a second, I need a bug number for the proper commit message first :)
Assignee | ||
Comment 1•13 years ago
|
||
Assignee: nobody → marky
Attachment #565566 -
Flags: review?(benjamin)
Updated•13 years ago
|
Attachment #565566 -
Flags: review?(benjamin) → review+
Pushed to mozilla-inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/d2241309d83c (This was also pushed to try, https://hg.mozilla.org/try/rev/afccba9817a4, linux64 debug+release only, both green) This is fine to close on inbound->m-c merge.
Flags: in-testsuite-
Target Milestone: --- → mozilla10
Comment 3•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d2241309d83c
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•