692903 - InferSpew should identify the scripts it talks about in more detail

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jim Blandy :jimb]

Attachment: Identify scripts more helpfully in InferSpew output.

Still more trivia.

This patch delays assigning id numbers to scripts until the first time the id is
actually retrieved, and at that point produces an InferSpew message
identifying the script by id, address, url and line number. This means that
we only identify scripts we actually mention in InferSpew output.

If JSScript::id had users other than jsinfer, this wouldn't be appropriate.

With this patch applied, we get output like this, the first time a given script is mentioned:

[infer] script #2: 0x7ffff5906660 /home/jimb/moz/dbg/js/src/jit-test/lib/prolog.js:1
[infer] typeSet: T0x9ff748 bytecode0 #2
...

Comment 1

[Brian Hackett [Laid off!]]

Comment on attachment 565622 [details] [diff] [review]
Identify scripts more helpfully in InferSpew output.

The script file/line numbers are also available when the compartment's types get printed out, though that only happens after execution finishes with INFERFLAGS=result/full

Comment 2

[Jim Blandy :jimb]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6576946586f4

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/mozilla-central/rev/f1f27d2354da