Closed Bug 692926 Opened 8 years ago Closed 8 years ago

Labels in Task header pane have hard coded colors

Categories

(Calendar :: Tasks, defect)

x86
All
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file)

The labels in Task header pane are hard coded black. On High Contrast themes with black backgrounds the labels aren't readable.
The labels in TB's header pane are using WindowText as color. With this patch we follow this. On Mac TB is still using black, so I leave the Mac part as it is.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #565645 - Flags: review?(bv1578)
Comment on attachment 565645 [details] [diff] [review]
Use WindowText color

It works fine.
r+

Generally speaking, would it be wrong to not assign at all the color to the text?
Attachment #565645 - Flags: review?(bv1578) → review+
(In reply to Decathlon from comment #2)
> Generally speaking, would it be wrong to not assign at all the color to the
> text?

Generally yes. But with defining we are on the save side. Personas could change the text color (doesn't happen now, but maybe with the future Tabs on Top implementation) or on a higher layer the text color will be changed and all childs inherit this and we have to redefine the color.
Fallen: is it okay to land on comm-aurora and comm-beta?
Pushed to comm-central http://hg.mozilla.org/comm-central/rev/a915d25fcece
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Trunk
Pushed to comm-aurora http://hg.mozilla.org/releases/comm-aurora/rev/9ba50533feff
Target Milestone: Trunk → 1.0b9
Pushed to comm-beta http://hg.mozilla.org/releases/comm-beta/rev/35e835034a3e
Target Milestone: 1.0b9 → 1.0b8
You need to log in before you can comment on or make changes to this bug.