Closed Bug 69296 Opened 25 years ago Closed 24 years ago

irc URL with # doesn't work

Categories

(Other Applications Graveyard :: ChatZilla, defect)

defect
Not set
critical

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: jwbaker, Assigned: rginda)

References

()

Details

Attachments

(1 file)

Linux 2001-02-18-06. The browser crashes with a segmentation fault when an irc URL is typed into the URL bar like this: irc://server/#channel also irc:///# I think the "#" is the important part.
I just checked and this definitely hoses the windows build as well. It doesn't crash, but it loops at 100% CPU time and is unresponsive. Marking all/all.
Keywords: crash
OS: Linux → All
Hardware: PC → All
The errors I am gettin here: Gdk-ERROR **: BadAlloc (insufficient resources for operation) serial 5700 error_code 11 request_code 53 minor_code 0 Gdk-ERROR **: BadDrawable (invalid Pixmap or Window parameter) serial 5703 error_code 9 request_code 70 minor_code 0 And then GDK calls exit(1)
On 2001050404 Win2k trunk, I neither get a crash nor hang by clicking on irc://irc.concentric.net/#baz . Instead, I get a small pop-up window, displaying: <html><body></body></html> and a strange title (I'll attach a screenshot).
Keywords: hang
Keywords: crash, hang
Keywords: crash
The crashing seems to not happen anymore, but it definitely doesn't like having a '#' in the url. On Linux w/ KDE I get the same little window, but with no title.
Keywords: crash
The fact that it works if you already have a chatzilla window open makes me think this bug has to do with opening a XUL file with a query string. When chatzilla is started with a particular URL in mind, we append that url to the xul file name. <http://lxr.mozilla.org/mozilla/source/extensions/irc/js/lib/chatzilla-service.js#137> 137 w.openDialog("chrome://chatzilla/content/chatzilla.xul?" + 138 channel.URI.spec, "_blank", 139 "chrome,menubar,toolbar,resizable"); I'll bet the # confuses the openDialog code. The way we pass in the url causes issues with the use of persist= as well. chatzilla.xul?irc://foo and chatzilla.xul are considered different by the persist code, so your window size, and visiblility of some UI elements will not be the same. I'd suggest we use the "extra argument" parameter of openDialog to pass in the url instead. That should fix the persist problem, and work around this one. Filing a XUL bug with a testcase would be a good thing too :)
Status: NEW → ASSIGNED
I've got this fixed in my local tree, and will include it in the megapatch in bug 89713.
Depends on: 89713
*** Bug 96361 has been marked as a duplicate of this bug. ***
Summary: Browser crashes with segmentation fault on irc URL → irc URL with # doesn't work
fix checked in
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Product: Core → Other Applications
Status: RESOLVED → VERIFIED
Product: Other Applications → Other Applications Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: