692966 - Zeus config returns responses with Content-Type text/html, not application/json

Status: RESOLVED FIXED

(Cloud Services :: Operations: Miscellaneous, task)

Description

[Richard Newman [:rnewman]]

$content_type = "text/html; charset=UTF-8";
  ...
     http.sendResponse("401 Node reassignment", $content_type, '"server request: node reassignment"', "");

The PHP and Python servers use application/json:

  Components.utils.import("resource://services-sync/main.js");
  let url = Weave.Service.storageURL + "meta/global";
  JSON.stringify(new (Weave.Resource)(url).get().headers);

  > "{\"content-type\":\"application/json\",\"strict-transport-security\":\"max-age=86400\",\"date\":\"Fri, 07 Oct 2011 22:19:45 GMT\",\"connection\":\"Keep-Alive\",\"x-weave-timestamp\":\"1318025985.88\",\"content-length\":\"258\"}"

If we ever end up validating responses prior to parsing, this will end badly.

Comment 1

[:Atoll]

Changed the "sync database health check" in { dev, test, stage, phx, scl2 } to return application/json rather than text/html.

Comment 2

[Richard Newman [:rnewman]]

I have amended my patch for Bug 692714 to not mention the discrepancy.

Thanks, atoll!